Introduce parameterized query attributes for GrantTypeSqlQueryBuilder - #2931
Open
aktaskaan wants to merge 12 commits into
Open
Introduce parameterized query attributes for GrantTypeSqlQueryBuilder#2931aktaskaan wants to merge 12 commits into
aktaskaan wants to merge 12 commits into
Conversation
… to enhance security and flexibility in dynamic query construction. Tightened field ID validation in `SortOrderQueryBuilder`
aktaskaan
force-pushed
the
ccd_5259_ccd_6209
branch
from
July 24, 2026 12:40
8f603a3 to
28db210
Compare
patelila
reviewed
Jul 27, 2026
|
|
||
| public static final String CASE_ACCESS_CATEGORY = "data" + " #>> '{CaseAccessCategory}'"; | ||
|
|
||
| public static final String JURISDICTION_PARAM = "jurisdiction_%s_%s"; |
Contributor
There was a problem hiding this comment.
These ABAC parameter names are predictable and share the same namespace as user search criteria params. A user field like case.region_1_basic is allowed, becomes
region_1_basic, and is bound after ABAC params in SearchQueryFactoryOperation, overwriting this predicate value. Please use a reserved/collision-proof prefix for all ABAC
params and add a regression test.
Supporting refs if needed:
SearchQueryFactoryOperation.java:89-90
Criterion.java:26-27
FieldMapSanitizeOperation.java:19
…e query safety, enforce collision checks, and update test cases for parameter consistency validation.
…update BeftaFW version to 9.2.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-5259
https://tools.hmcts.net/jira/browse/CCD-6209
Change description
Does this PR introduce a breaking change? (check one with "x")