Repository navigation
fix(dma): retain controller ownership across forgotten guards - #20
Draft
sanchuanhehe wants to merge 1 commit into
Draft
sanchuanhehe wants to merge 1 commit into
sanchuanhehe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short DMA controller reborrow could launch a transfer, forget its guard, and regain the original controller token while retained hardware state remained live. Require a
'staticcontroller lifetime at the three experimental owned-guard launch methods. Moving the originalPeripherals::DMAtoken remains supported; add negative and positive documentation tests.Validation: standalone development graph host tests WS63/BS21/WS53 351/220/432, all three RISC-V Clippy checks, WS63/BS21 doctests, and owned-token host/target consumers pass. The old revision accepts the reborrow counterexample; this change rejects it with E0521/E0499. WS63 DMA example and BS21 example build/check pass. BS20 locked check is separately blocked by its stale lockfile.
This changes a compile-time ownership boundary only. No hardware or QEMU run, register behavior change, or stable API graduation. Normal completion bus drain, cache ownership and higher-level DMA safety remain unproven. Stacked on the timer lifecycle branch to keep this review limited to one unit.