chore: change the liverootpath and archiverootpath to absolute paths as default#656
Merged
ata-nas merged 3 commits intoFeb 20, 2025
Conversation
ata-nas
force-pushed
the
371-chore-change-the-liverootpath-and-archiverootpath-to-absolute-paths-as-default
branch
from
44ba365 to
695935c
Compare
ata-nas
commented
Feb 18, 2025
Contributor
Author
ata-nas
left a comment
ata-nas
left a comment
There was a problem hiding this comment.
Some general comments to consider.
ata-nas
requested review from
AlfredoG87,
Nana-EC,
georgi-l95,
jsync-swirlds and
mattp-swirldslabs
Nana-EC
reviewed
Feb 18, 2025
ata-nas
force-pushed
the
371-chore-change-the-liverootpath-and-archiverootpath-to-absolute-paths-as-default
branch
from
004934d to
a7b222c
Compare
…as default - change persistence config liveRootPath default to /opt/hashgraph/blocknode/data/live - change persistence config archiveRootPath default to /opt/hashgraph/blocknode/data/archive - both configs now use Path instead of String for their type - docker user now has access to /opt - change persistence config key archiveBatchSize to archiveGroup size for improved semantics (todo left from the past) - config record no longer creates roots, it is just a value holder, it has no logic and is no decision maker - remove deprecated usage of ConfigrationHolder (it also caused issues for tests) - updated tests to pass with the new default paths Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
- the preconditions change to only require non-null values - if a blank value exists (no matter it's source) it will be used instead of falling back to the default - tests are updated to reflect the change - addressing PR comment Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
ata-nas
force-pushed
the
371-chore-change-the-liverootpath-and-archiverootpath-to-absolute-paths-as-default
branch
from
a85a0b2 to
b65a7e9
Compare
ata-nas
deleted the
371-chore-change-the-liverootpath-and-archiverootpath-to-absolute-paths-as-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Related Issue(s)
Closes #371