Skip to content

OTP Email#52

Open
AaronJackson wants to merge 1 commit into
hic-infra:mainfrom
AaronJackson:otp-email
Open

OTP Email#52
AaronJackson wants to merge 1 commit into
hic-infra:mainfrom
AaronJackson:otp-email

Conversation

@AaronJackson
Copy link
Copy Markdown
Member

Built as a separate container so that it appears as a separate release in GitHub, just in case others are using this repo for their Keycloak and don't want email-based OTP.

@AaronJackson AaronJackson requested a review from manics November 27, 2025 15:24
Copy link
Copy Markdown
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you reviewed the code in https://github.com/mesutpiskin/keycloak-2fa-email-authenticator/ ? We can probably ask the software team if not.

Comment thread container/Dockerfile.eotp Outdated
Comment thread .github/workflows/ci.yml
uses: docker/build-push-action@v6
with:
context: ./container
file: ./container/Dockerfile.eotp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try adding something like build-args: BASE_IMAGE=${{ steps.meta.outputs.tags[0] }} (I don't know if array indexing works, you might have to use an indexing function)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works without indexing, but I guess if we decide to add another tag to the first container it will break

Built as a separate container so that it appears as a separate release
in GitHub, just in case others are using this repo for their Keycloak
and don't want email-based OTP.
@AaronJackson
Copy link
Copy Markdown
Member Author

Have you reviewed the code in https://github.com/mesutpiskin/keycloak-2fa-email-authenticator/ ? We can probably ask the software team if not.

I've looked through it and couldn't see anything obvious. Will have a more thorough look now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants