[erika-wallace]

Summary

This PR migrates the data:pg:credentials commands — create, destroy, index, rotate, url — to @heroku/sdk (part 2 of the data:pg subcommand migration, following #4001), replacing raw this.heroku/this.dataApi calls and heroku-cli-util's utils.AddonResolver/utils.pg helpers with the SDK's databaseCredentialExtensions.

Command Changes

• create.ts, destroy.ts, index.ts, rotate.ts, and url.ts now call data.databaseCredential.{create,destroy,list,rotate,getUrl} via createSDK(this.heroku, {extensions: [databaseCredentialExtensions]}), instead of resolving the add-on and building REST paths by hand.
• data:pg:credentials:index detects non-Advanced-tier databases via the SDK's NotAdvancedDatabaseError (instead of an explicit tier check before fetching credentials) and still suggests pg:credentials as before.
• data:pg:credentials:rotate is restructured around a beforeRotate callback passed to data.databaseCredential.rotate, which now owns resolving credentials/attachments and building the confirmation preview; the command's private getCredsAndAttachments/getCredToRotate methods are removed since the SDK resolves and previews the rotation internally.
• data:pg:credentials:url now reads credentialConnectionInfo.{database,host,port,user,password,url,credName} directly from data.databaseCredential.getUrl(...), instead of fetching raw credential info and building the postgres:// URL by hand.
• Deleted src/lib/data/parse-attachment-factors.ts and its test — attachment-namespace parsing now comes from @heroku/sdk/resources/data/postgres-database's parseAttachmentFactors.

Test Changes

• Unit tests for all five credential commands are migrated from nock to mockSDKData/mockSDK stubs (test/helpers/mock-sdk.ts), with mocked resolve/reject shapes to match the SDK's return types

V12-CHANGES.md

• User-visible behavior changes: data:pg:credentials:url and data:pg:credentials:destroy error messages are now plain, uncolored text, since the SDK throws plain Errors for these cases.

Note: src/commands/data/pg/attachments/create.ts and src/commands/pg/credentials.ts aren't migrated in this PR, so their use of sortByLeaderAndName/sortByOwnerAndName/presentCredentialAttachments (previously imported from now-SDK-typed credential-utils.ts/lib/pg/util.ts) is temporarily inlined with a // TODO: Remove this once ... is migrated to use the SDK comment, to avoid taking on their migration here.

Type of Change

Breaking Changes (major semver update)

• Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

• feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

• fix: Bug fix
• deps: Dependency upgrade
• revert: Revert a previous commit
• chore: Change that does not affect production code
• refactor: Refactoring existing code without changing behavior
• test: Add/update/remove tests

Testing

Notes:

Requires access to a Heroku app with an Advanced-tier database and a classic (non-Essential) tier database.

Setup:

1. Pull down this branch
2. npm i && npm run build

Steps:

Advanced-tier database

1. Create a credential. Verify the credential is created and the data:pg:attachments:create/pg:psql commands print with the right names

./bin/run data:pg:credentials:create ADVANCED_DATABASE --app APP --name my-credential

2. List credentials. Verify the credential table renders with attachment and rotation-status columns, including my-credential

./bin/run data:pg:credentials ADVANCED_DATABASE --app APP

3. Get a credential's connection URL. Verify the connection info string and connection URL both resolve to my-credential's host/port/user/password

./bin/run data:pg:credentials:url ADVANCED_DATABASE --app APP --name my-credential

4. Rotate a single credential. Verify the confirmation prompt lists the affected apps and the credential rotates

./bin/run data:pg:credentials:rotate ADVANCED_DATABASE --app APP --name my-credential

5. Rotate all credentials, forced. Verify the confirmation prompt mentions force-rotating and all credentials rotate

./bin/run data:pg:credentials:rotate ADVANCED_DATABASE --app APP --all --force

6. Destroy a credential. Verify the credential destroys successfully

./bin/run data:pg:credentials:destroy ADVANCED_DATABASE --app APP --name my-credential

7. List credentials. Verify my-credential is no longer listed

./bin/run data:pg:credentials ADVANCED_DATABASE --app APP

Classic (non-Essential) tier database

1. Create a credential. Verify the credential is created and the addons:attach/pg:psql commands print with the right names

./bin/run data:pg:credentials:create CLASSIC_DATABASE --app APP --name my-credential

2. List credentials. Verify the error suggests pg:credentials with the correct database name instead of listing credentials

./bin/run data:pg:credentials CLASSIC_DATABASE --app APP

3. List credentials. Verify the credential table renders with attachment and rotation-status columns, including my-credential

./bin/run pg:credentials CLASSIC_DATABASE --app APP

4. Get a credential's connection URL. Verify the connection info string and connection URL both resolve to my-credential's host/port/user/password

./bin/run data:pg:credentials:url CLASSIC_DATABASE --app APP --name my-credential

5. Rotate a single credential. Verify the confirmation prompt lists the affected apps and the credential rotates

./bin/run data:pg:credentials:rotate CLASSIC_DATABASE --app APP --name my-credential

6. Rotate all credentials, forced. Verify the confirmation prompt mentions force-rotating and all credentials rotate

./bin/run data:pg:credentials:rotate CLASSIC_DATABASE --app APP --all --force

7. Destroy a credential. Verify the credential destroys successfully

./bin/run data:pg:credentials:destroy CLASSIC_DATABASE --app APP --name my-credential

8. List credentials. Verify my-credential is no longer listed

./bin/run pg:credentials CLASSIC_DATABASE --app APP

Screenshots (if applicable)

Related Issues

GUS work item: W-23385448

[github-actions]

This PR is labeled size/XL (1988 lines of code churn, excluding docs, package-lock.json, and generated files).

Large PRs are harder to review well. If it can be split into smaller, independently reviewable pieces, consider doing so. This is a suggestion, not a blocker — the check still passes.

[jdodson]

Approved.

Manual tests all pass, good job.

AI had one thing it considers a blocker. Worth looking into.

• Data-service configuration regression: migrated credential calls do not preserve the configured data host or HEROKU_DATA_CONTROL_PLANE header. This can break environments using those overrides.

[erika-wallace]

Approved.

AI had one thing it considers a blocker. Worth looking into.

• Data-service configuration regression: migrated credential calls do not preserve the configured data host or HEROKU_DATA_CONTROL_PLANE header. This can break environments using those overrides.

@jdodson This will be addressed in W-24610335