Repository navigation
fix: remove Heroku CLI bin dir from PATH on Windows uninstall - #3967
Open
heroku-johnny wants to merge 1 commit into
Open
heroku-johnny wants to merge 1 commit into
heroku-johnny wants to merge 1 commit into
Conversation
Adds an NSIS customization file with un.RemoveFromPath and un.onUninstSuccess so that $INSTDIR\bin is removed from the user's HKCU PATH registry value when the Windows installer uninstalls the CLI. Closes #1883 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
scripts/windows-installer-customization.nsiwith an NSISun.RemoveFromPathfunction andun.onUninstSuccesscallback, wired into the installer viaoclif.nsisCustomizationinpackage.json.When the Windows installer's uninstaller runs, it now removes
$INSTDIR\binfrom the user'sHKCU\Environment\PATHregistry value in addition to deleting the files.Type of Change
Patch Updates (patch semver update)
Testing
Steps:
npm run pack:win(requires NSIS on Windows)herokuis accessible in a new shell%PATH%no longer contains the Heroku bin dirRelated Issues
GitHub issue: #1883