Skip to content

fix: order ui accent before nested config tables #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akbash-bot wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −4
Open

fix: order ui accent before nested config tables #2698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ae63e0
fix: order ui accent before nested config tables
akbash-bot Aug 12, 2026
dfb0ca1
test: reject duplicate ui accent examples
akbash-bot Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,10 @@ const DEFAULT_CONFIG: &str = r##"# herdr configuration
# distinct static glyphs for blocked, working, done, idle, and unknown states.
# status_indicators = "dots"

# Accent color for highlights, borders, and navigation UI.
# Accepts: hex (#89b4fa), named colors (cyan, blue, magenta), or rgb(r,g,b)
# accent = "cyan"

# Expanded agent rows. Built-ins are state_icon, state_text, workspace, tab, pane, agent,
# terminal_title, and terminal_title_stripped.
# Custom values reported through pane metadata use a $name token.
Expand All @@ -377,10 +381,6 @@ const DEFAULT_CONFIG: &str = r##"# herdr configuration
# row_gap = 0
# rows = [["state_icon", "workspace"], ["branch", "git_status"]]

# Accent color for highlights, borders, and navigation UI.
# Accepts: hex (#89b4fa), named colors (cyan, blue, magenta), or rgb(r,g,b)
# accent = "cyan"

# Background notification popup delivery
[ui.toast]
# off = disable pop-up notifications
Expand Down Expand Up @@ -924,6 +924,14 @@ fn main() -> io::Result<()> {
mod tests {
use super::*;

#[test]
fn default_config_lists_ui_accent_before_nested_tables() {
let accent = DEFAULT_CONFIG.find("# accent = \"cyan\"").unwrap();
let sidebar = DEFAULT_CONFIG.find("# [ui.sidebar.agents]").unwrap();

assert!(accent < sidebar);
}

#[test]
fn nested_herdr_blocks_when_env_is_set() {
let config = config::Config::default();
Expand Down
Loading