feat: upgrades & fixes - #12
Merged
Merged
Conversation
- Fix cache loading bug where Find() always returned ErrCacheNotFound - Replace Must() panic-based error handling with proper error returns - Fix directory walking race condition in finder logic - Add proper resource management with deferred file closing - Remove unused struct fields (MaxRecursion, CurrentRecursion) - Add comprehensive golangci-lint configuration - Fix all linting issues: unchecked errors, unused variables
- Add config package tests: Default(), Read(), Write(), JSON marshaling - Add UI table tests: alignment, padding, edge cases, multi-column support - Add gofind tests: ParsePath() tilde expansion, Match struct operations - Add cache tests: Set/Find operations, expiration, error handling - Achieve 100% coverage on ui package, 44% on config, 25% on gofind - All tests passing with proper error handling and edge case coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.