[fendor]

Fixes #12573

Updates the cabal-testsuite to use UTF-8 encoding appropriately, otherwise the tests crash due to the same encoding error that plagues -unit @rsp.

---

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

[fendor]

I think, in theory, it is worth reviewing every occurrence of Data.ByteString.Char8 and review it for its correctness.
While skimming the codebase, I found multiple locations where the usage is dubious (i.e. I wasn't immediately convinced the usage was correct).

[Mikolaj]

I think, in theory, it is worth reviewing every occurrence of Data.ByteString.Char8 and review it for its correctness. While skimming the codebase, I found multiple locations where the usage is dubious (i.e. I wasn't immediately convinced the usage was correct).

Would it fit this PR or would a new PR be better? If the latter, could you kindly open a ticket so that we don't forget?

[Mikolaj]

Thank you!

[fendor]

Would it fit this PR or would a new PR be better? If the latter, could you kindly open a ticket so that we don't forget?

I think another PR is better, this fixes a real bug, the other occurrences could be benign. Also, I am not committing to review the whole cabal codebase 😬

[fendor]

Thank you all for the thorough review, not my proudest PR, given the amount of oversights :D

[fendor]

I created an issue: #12580