Repository navigation
Conversation
The program search path of each package started from the search path of the compiler's ProgramDb, which leaked the extra-prog-path of the local packages.
5 of 6 tasks
The program search path used to find programs is now consistently structured to avoid duplicates and enforce the following ordering: (B) Programs specified in `build-tool-depends` (E) Programs found from `--extra-prog-path` (P) Fallback search on `PATH`. See Note [Program search paths] in Distribution.Simple.Configure. Fixes haskell#12544.
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way program search paths were handled was just a mess. I tried to bring some order to it, explained in Note [Program search paths]:
--with-PROG=<...>ghc-pkgnext to where we foundghc--extra-prog-pathPATHQA notes: pass various kinds of
--with-PROG,build-tool-depends:...etc and check they abide by the order above. A lot of these are kind of fiddly to test by hand; see for exampleExtraProgPathTopLevelwhich shows that a top-levelextra-prog-pathonly applies to the local package, not to its dependencies, andProgramSearchPathwhich checks the ordering above.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: