Skip to content

Add a label for one more review - #12504

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:ci/needs-second-review
Nov 10, 2026
Merged

mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:ci/needs-second-review

Conversation

@philderbeast

@philderbeast philderbeast commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Pull requests that already have one approval might be the easiest to approve in review. This change adds (and removes) such a label so they're easier to find, [1️⃣ more approval needed].


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Nov 4, 2026
@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Nov 4, 2026
@mergify

mergify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

🚫 Left the queue · conflict with base branch

2 h 18 min in the queue, with no time running CI.

So far

  • ✅ Entered the queue Fri 6 Nov, 18:56 · rule default · triggered by rule Put pull requests in the rebase+merge queue
  • 🚫 Left the queue 21:14 · 42f26ee

Reason

The pull request conflicts with master

Conflicting file: .github/mergify.yml

Before this, the pull request was held in the queue behind 1 pull request ahead of it.

Hint

You should update or rebase your pull request. A pull request queued by a rule comes back to the queue once updated, as long as the rule still matches.

If it was queued with a command, post a new @mergifyio queue comment to requeue it.

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot mentioned this pull request Nov 6, 2026
1 of 2 tasks
@mergify mergify Bot added dequeued waiting too long automatically set by Mergify to trigger a warning and removed queued labels Nov 6, 2026
@zlonast

zlonast commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

@philderbeast rebase?

@philderbeast
philderbeast force-pushed the ci/needs-second-review branch from 42f26ee to d579807 Compare November 10, 2026 11:30
@mergify mergify Bot added queued and removed dequeued labels Nov 10, 2026
@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into master as 90fa465 at 15:22 UTC

2 h 14 min in the queue, 2 h 2 min of it CI.

So far

12 merge conditions met
  • #review-threads-unresolved = 0 · required by GitHub branch protection
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of · required by GitHub branch protection:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of · required by GitHub branch protection:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of · required by GitHub branch protection:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of · required by GitHub branch protection:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of · required by GitHub branch protection:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of · required by GitHub branch protection:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of · required by GitHub branch protection:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of · required by GitHub branch protection:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of · required by GitHub branch protection:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Times in UTC · dashboard · how the merge queue works

@mergify
mergify Bot merged commit 90fa465 into haskell:master Nov 10, 2026
61 checks passed
@mergify mergify Bot removed the queued label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period waiting too long automatically set by Mergify to trigger a warning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants