Repository navigation
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
zlonast
force-pushed
the
zlonast/no-optJSP-before-9.12
branch
from
October 7, 2026 17:49
7ad37df to
688c9c7
Compare
zlonast
changed the title
-optJSP to GHC < 9.12-optJSP to GHC < 9.10.2
zlonast
force-pushed
the
zlonast/no-optJSP-before-9.12
branch
2 times, most recently
from
October 7, 2026 17:52
4c868e2 to
4f4782a
Compare
leana8959
reviewed
Oct 30, 2026
leana8959
left a comment
leana8959
left a comment
Collaborator
There was a problem hiding this comment.
Would it be helpful to warn the user when the flag is not passed to GHC?
zlonast
added a commit
to zlonast/cabal
that referenced
this pull request
Nov 4, 2026
Review feedback on haskell#12398: 'renderGhcOptions' now omits -optJSP for older compilers, which would silently ignore the user's jspp-options. Emit a build-time warning in that case, naming the compiler version found. Also rename the ghc912 binding (leftover from the original PR title) to jsppSupported. Co-authored-by: Léana <leana.jiang+git@icloud.com>
Collaborator
Author
|
@leana8959 I like your idea |
leana8959
reviewed
Nov 4, 2026
| "Ignoring 'jspp-options': -optJSP is only supported by GHC 9.10.2 and later (found GHC " | ||
| ++ prettyShow v | ||
| ++ ")" | ||
| _ -> return () |
Collaborator
There was a problem hiding this comment.
Maybe we should also warn in the case where we don't know the compiler used (Nothing)? It is currently inconsistent with the filtering in the other file.
mergify
Bot
added
the
👻 haunting the review queue
Review feedback on haskell#12398: 'renderGhcOptions' now omits -optJSP for older compilers, which would silently ignore the user's jspp-options. Emit a build-time warning in that case, naming the compiler version found, and likewise when the compiler version is unknown. Also rename the ghc912 binding (leftover from the original PR title) to jsppSupported. Co-authored-by: Léana <leana.jiang+git@icloud.com>
zlonast
force-pushed
the
zlonast/no-optJSP-before-9.12
branch
from
November 7, 2026 13:29
9fa00e4 to
d6c13ac
Compare
mergify
Bot
removed
the
👻 haunting the review queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jspp-optionsfield is rendered asghc -optJSP<opt>, but that flag only exists since GHC 9.10.2, so a package usingjspp-optionscould not be built at all with GHC < 9.10.2.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.