[zlonast]

fix: #12140

debug-info: False ​​are treated as NoDebugInfo, and debug-info: True ​​are treated as NormalDebugInfo

---

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[philderbeast]

If we're parsing booleans for debug-info in the project, would that also apply to the command line? If not, is error the best message?

$ cabal build --help
...
--enable-debug-info[=n]        Emit debug info (n is 0--3, default is 0)
--disable-debug-info           Don't emit debug info

$ cabal run cabal-install:exe:cabal -- build all --dry-run \
   --enable-debug-info=True
...
Can't parse debug info level True

HasCallStack backtrace:
  error, called at src/Distribution/Simple/Compiler.hs:383:8 in
  Cabal-3.19.0.0-inplace:Distribution.Simple.Compiler

$ cabal-3.18.1.0 build all --dry-run --enable-debug-info=True
Can't parse debug info level True
CallStack (from HasCallStack):
  error, called at src/Distribution/Simple/Compiler.hs:392:8 in
  Cabal-3.18.1.0-inplace:Distribution.Simple.Compiler

[zlonast]

@philderbeast Thanks for such a detailed review, yes, I think this approach should be applied to the command line as well.

[Mikolaj]

Well done!

[mergify]

✅ Merged into master as 8ded4e7 at 04:30 UTC

1 h 58 min in the queue, 1 h 47 min of it CI.

So far

• ✅ Entered the queue Sat 7 Nov, 02:32 · rule default · triggered by rule Put pull requests in the rebase+merge queue
• ✅ Passed · draft merge queue: merged #12202: fix(Cabal): Accept boolean values for debug-info and optimization levels #12542
• ✅ Merged 04:30 · 8ded4e7 · merge

12 merge conditions met

• #review-threads-unresolved = 0 · required by GitHub branch protection
• github-review-approved · required by GitHub branch protection
• any of · required by GitHub branch protection:
  • check-success = Doctest Cabal
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
• any of · required by GitHub branch protection:
  • check-success = Meta checks
  • check-neutral = Meta checks
  • check-skipped = Meta checks
• any of · required by GitHub branch protection:
  • check-success = docs/readthedocs.org:cabal
  • check-neutral = docs/readthedocs.org:cabal
  • check-skipped = docs/readthedocs.org:cabal
• any of · required by GitHub branch protection:
  • check-success = Validate post job
  • check-neutral = Validate post job
  • check-skipped = Validate post job
• any of · required by GitHub branch protection:
  • check-success = fourmolu
  • check-neutral = fourmolu
  • check-skipped = fourmolu
• any of · required by GitHub branch protection:
  • check-success = hlint
  • check-neutral = hlint
  • check-skipped = hlint
• any of · required by GitHub branch protection:
  • check-success = Bootstrap post job
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
• any of · required by GitHub branch protection:
  • check-success = whitespace
  • check-neutral = whitespace
  • check-skipped = whitespace
• any of · required by GitHub branch protection:
  • check-success = Check sdist post job
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
• any of · required by GitHub branch protection:
  • check-success = Changelogs
  • check-neutral = Changelogs
  • check-skipped = Changelogs

_{Times in UTC · dashboard · how the merge queue works}