[philderbeast]

The failing test for #12171 and its fix.

$ cabal test cabal-install:parser-tests
...
Build profile: -w ghc-9.10.3 -O1
...
Running 1 test suites...
Test suite parser-tests: RUNNING...
project files parsec tests                                                                                                                                                                                                                            
  read packages:                                    OK
  read packages glob:                               FAIL
    Exception: Error: [Cabal-7167]
    Error parsing project file cabal.glob.project:
    
    cabal.glob.project:3:28: error:
      unexpected ','
      expecting white space, string, identifier or end of input
          3 | packages: */*.cabal ../{foo,bar}/
            |                            ^    
    
    Use -p '/read packages glob/' to rerun this test only.

I'll squash commits before applying the merge label if this pull request is approved.

---

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added.

[Mikolaj]

Where are the globs handled in the code? I only see the curly braces syntax, which is only the half of the example in the issue.

[philderbeast]

Where are the globs handled in the code? I only see the curly braces syntax, which is only the half of the example in the issue.

Globs are handled in checkIsFileGlobPackage:

cabal/cabal-install/src/Distribution/Client/ProjectConfig.hs

Lines 1283 to 1308 in 3c15ba7

	checkIsFileGlobPackage pkglocstr =
	case simpleParsec pkglocstr of
	Nothing -> return Nothing
	Just glob ->
	Just <$> do
	matches <- matchFileGlob glob
	case matches of
	[]
	| isJust (isTrivialRootedGlob glob) ->
	return
	( Left
	( BadPackageLocationFile
	(BadLocNonexistentFile pkglocstr)
	)
	)
	[] -> return (Left (BadLocGlobEmptyMatch pkglocstr))
	_ -> do
	(failures, pkglocs) <-
	partitionEithers
	<$> traverse checkFilePackageMatch matches
	return $! case (failures, pkglocs) of
	([failure], [])
	| isJust (isTrivialRootedGlob glob) ->
	Left (BadPackageLocationFile failure)
	(_, []) -> Left (BadLocGlobBadMatches pkglocstr failures)
	_ -> Right pkglocs

The simpleParsec function calls parsecGlob by way of instances for Parsec RootedGlob and Parsec Glob.

cabal/Cabal/src/Distribution/Simple/Glob/Internal.hs

Lines 97 to 104 in 3c15ba7

	parsecGlob :: CabalParsing m => m GlobPieces
	parsecGlob = some parsecPiece
	where
	parsecPiece = P.choice [literal, wildcard, union]
	wildcard = WildCard <$ P.char '*'
	union = Union . toList <$> P.between (P.char '{') (P.char '}') (P.sepByNonEmpty parsecGlob (P.char ','))
	literal = Literal <$> some litchar

We only needed to fix the curly braces parsing. I've changed the pull request's title and the changelog to say that.