Fix gpg signature generation for tag and simplify signed data#16
Fix gpg signature generation for tag and simplify signed data#16alexey-igrychev wants to merge 1 commit into
Conversation
daurnimator
left a comment
daurnimator
left a comment
There was a problem hiding this comment.
Use tag object ID instead of head commit as git note object ID
Use note object ID as signed data
Is there a rationale for this written up somewhere?
| git -c diff.indentHeuristic=false diff-tree -p "$1"..HEAD \ | ||
| | git patch-id --stable \ | ||
| | cut -d' ' -f1 | ||
| printf "%s" "$(git show-ref "$1" -s)" |
There was a problem hiding this comment.
In such a way, I would like to sign the object ID without the new line character.
- Use tag object ID instead of head commit as git note object ID - Use note object ID as signed data
alexey-igrychev
force-pushed
the
fix_gpg_signature_generation_for_tag
branch
from
1a205c2 to
64b05ac
Compare
|
@daurnimator First of all, thank you very much for the repository and ready-to-use workflow. I want to integrate this utility (and approach in general) with other tools to organize internal processes. |
|
@daurnimator I apologize for the direct appeal, but could you please give feedback. |
2 participants
The creation of this PR is motivated by the lack of tagging support (it is possible to sign a linked commit) and the overly complicated data that is signed.
It is suggested to use object ID (commit ID or tag object ID) instead of HEAD commit ID as the git note object ID.
It is also proposed to use object ID as the data to be signed. In this case, verification is simplified and the user does not need to use a utility for verification (the user can implement the verification with whatever, wherever and however he wants).
These changes break compatibility with previous versions and the version must be changed.