Skip to content

Fixing shape support in cgtoaa module#1515

Merged
amjjbonvin merged 37 commits into
CG-HADDOCKfrom
CG-HADDOCK-shape
Apr 22, 2026
Merged

Fixing shape support in cgtoaa module#1515
amjjbonvin merged 37 commits into
CG-HADDOCKfrom
CG-HADDOCK-shape

Conversation

@amjjbonvin
Copy link
Copy Markdown
Member

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Modifications / enhancements are reflected on the haddock3 user-manual
  • CHANGELOG.md is updated to incorporate new changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Modified cgtoaa.cns to correctly handle a shape if present (fixing it and not including it in the morphing of the AA models onto the CG model of the complex.

Added a docking example illustrating protein-protein docking into a shape (both AA and CG)

TODO: update user manual with the information about the new docking example

Comment thread src/haddock/libs/libaa2cg.py
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libpdb.py
Comment thread src/haddock/modules/topology/topocg/__init__.py Outdated
Comment thread src/haddock/modules/refinement/cgtoaa/cns/cgtoaa.cns
Comment thread src/haddock/libs/libcns.py
Comment thread src/haddock/libs/libaa2cg.py Outdated
Comment thread src/haddock/libs/libaa2cg.py Outdated
@amjjbonvin amjjbonvin requested a review from rvhonorato April 16, 2026 13:18
@rversin
Copy link
Copy Markdown
Member

rversin commented Apr 19, 2026

I don't understand why some check fails here, as locally (on tintin) it doesn't fail, it actually succeeds. I don't know if need to fix a module or test script ?

@VGPReys
Copy link
Copy Markdown
Contributor

VGPReys commented Apr 20, 2026

I have two questions:

  • *_cg.pdb: where should those files be written ? in the module (XX_topocg) directory ?
  • *_cg.pdb: are those files used for backmapping ?

@rversin
Copy link
Copy Markdown
Member

rversin commented Apr 20, 2026

These files are used by CNS to build the topology files. They are written in the module directory (01_topocg). They are not used for backmapping.

@VGPReys
Copy link
Copy Markdown
Contributor

VGPReys commented Apr 20, 2026

Then let me fix this

@VGPReys
Copy link
Copy Markdown
Contributor

VGPReys commented Apr 20, 2026

I modified:

  • the uni-tests
  • some paths generation in the libaa2cg and topocg/__init__.py
  • added a removal of the *_cg.pdb files (that are temporary), when debug = false

@rversin
Copy link
Copy Markdown
Member

rversin commented Apr 20, 2026

Thank you very much Victor for your help !

@amjjbonvin amjjbonvin merged commit 0c61921 into CG-HADDOCK Apr 22, 2026
6 checks passed
@amjjbonvin amjjbonvin deleted the CG-HADDOCK-shape branch April 22, 2026 08:25
@github-project-automation github-project-automation Bot moved this to Done in CG Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants