Repository navigation
Onboarding: tell users who already pledged that their project stays as it was - #23
Draft
posthog[bot] wants to merge 2 commits into
Draft
posthog[bot] wants to merge 2 commits into
posthog[bot] wants to merge 2 commits into
Conversation
…mes the project you kept and that the new pledge isn't saved, instead of "Day 1 starts now." The create response for someone who already pledged now carries already_pledged and the kept project's title. The commit step stays on /start and shows them, and the server sends a project_already_pledged event so the discarded pledges can be counted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 1bdc5cbf-9b8a-46e5-9bf6-1cffb086d7f6
… signed pledge can't be signed again Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 1bdc5cbf-9b8a-46e5-9bf6-1cffb086d7f6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ProjectsController#createkeeps the first pledge on purpose (d5eb1d0), but its response did not say that it discarded the new pledge. So the commit step showed the normal success screen and went to /project.Origin
d5eb1d0Changes
already_pledged: trueand the kept project'stitle.project_already_pledgedgoes to PostHog from the server on this branch. Then the count of discarded pledges can be measured. Before, the report could not count it.flowchart LR A[Sign pledge on /start] --> B{Has a project?} B -- no --> C[Save, go to /project] B -- "yes (before)" --> D["'Day 1 starts now.' → old project"] B -- "yes (after)" --> E["'You already have a project.' + its title, stay on /start"]Note
If the user also has a pending buddy invite, the server still pairs them, but the page no longer goes to /buddy on its own. The Buddy tab and /project show the pairing.
Testing
bin/rails test: 302 runs, 2 failures. Both failures also occur onmainand do not touch this change (ProjectsControllerTesthours/leaderboard at line 292 andRewardTestpair week at line 96).location,already_pledgedandtitlefor a user who already pledged.bin/rubocopon the changed Ruby files: no offenses.node --checkon the Stimulus controller passes. The repo has no JS test runner.bin/rails test:system, because the sandbox has no Chrome for Selenium.Agent context
Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code