Repository navigation
feat(hardware): delegate permanent rejection decisions - #1606
Merged
lordbagel42 merged 1 commit intoNov 7, 2026
Merged
lordbagel42 merged 1 commit into
lordbagel42 merged 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1b502-4991-70ae-8d65-604261178064 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's this do?
Adds a grantable hardware permanent-rejection manager role: auto-approve their own nominations and approve/deny others, without admin powers. Existing review access is still required to nominate; undo stays admin-only.
show it works
Targeted hardware/role tests passed (73 runs, 315 assertions, no failures), including temporary permission, undo, and attribution checks. Notification rendering checks, RuboCop, and ERB lint passed; no generated tests retained.
Task review completed. Known follow-up: some navigation/audit links still require separate permissions and can deny access for role-only or mission-only reviewers. UI captures and verification details are in the Amp thread below.
ai?
Amp, including a Task subagent review: https://ampcode.com/threads/T-01a1b502-4991-70ae-8d65-604261178064