Skip to content

[Card Grants] Improve UI - #14806

Open
manu-gurudath wants to merge 55 commits into
mainfrom
mxg-improve-card-grant-ui
Open

manu-gurudath wants to merge 55 commits into
mainfrom
mxg-improve-card-grant-ui

Conversation

@manu-gurudath

@manu-gurudath manu-gurudath commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

every day, there's a new confused user in #hcb asking a card-grant related question

here are the biggest changes this pr does:

  • makes it super obvious that organizations control spending restrictions, not hcb
  • clearly shows the steps on how to use a card grant in a step-by-step list view format
  • rearranges buttons and contents on page to make card grant ui more intuitive

preview

Grant Management for Stagey M

cc @anishanne

@manu-gurudath
manu-gurudath requested a review from a team August 31, 2026 02:05
@manu-gurudath
manu-gurudath marked this pull request as draft August 31, 2026 02:05
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@anishanne

Copy link
Copy Markdown
Contributor

Can we add the name into the billing address/card details area? People ask us about that a lot.

manu-gurudath and others added 6 commits September 3, 2026 21:16
Restore the missing ERB tag in _grant_details, and make the controls
grid's buttons consistent: every cell is now a .grant-control column
whose button is bottom-pinned and full-width, matched as a descendant
so button_to's display:contents form no longer breaks the selector.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The _section_heading partial required an "own" local with no default,
but
the pre-authorization page renders it without one, raising
StrictLocalsError. Default own to true so the numbered steps still show.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L6yqqwNR5bJJcy6Ej6kpqs
Keep main's separate converted/canceled branches for the grantee view and
update the organizer show spec for the renamed section headings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VfcHsCGBdbSLfcH9BYtqpX
@manu-gurudath
manu-gurudath marked this pull request as ready for review October 3, 2026 22:36
@itmadden

Copy link
Copy Markdown
Contributor

Thanks for this PR, plenty of much needed improvements. Here's a couple of UX thoughts:

For the header card:

image image
Before After

I like:

  • The emphasis on the expiration date distinctly separate from the card details
  • The progress bar providing a glanceable indication of how much has been spent

Could be improved:

  • The contrast ratio could be improved especially with the badge, progress bar, and muted text. The old colorful status indicator and muted text were near the bottom with a lighter background.
  • The "Manage grant" button looks a little lonely in the corner.

The card details section looks a little bare when you're an organizer but not an admin:

image

And for the controls, it feels a little weird to have buttons inside of clickable cards where both lack icons:

image

I also think in general the eyebrow headers are a little difficult to read. Maybe we could restyle them or consider swapping them out for something else.

I like this help section, but I haven't seen this style for "All articles" anywhere before and it looks a little out of place:

image

Maybe we could consider pulling from "See all" on the homepage? Just an idea.

image

Overall I really like the direction you're going. Feel free to push back on any of these UX critiques as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread app/views/card_grants/_actions.html.erb Dismissed
Comment thread app/views/card_grants/_actions.html.erb Dismissed
Comment thread app/views/card_grants/_hero.html.erb Dismissed
@anishanne
anishanne requested a review from itmadden November 3, 2026 00:45
@garyhtou

garyhtou commented Nov 3, 2026

Copy link
Copy Markdown
Member

@itmadden , can you please do a 2nd pass here?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants