Repository navigation
[Card Grants] Improve UI - #14806
Open
manu-gurudath wants to merge 55 commits into
Open
[Card Grants] Improve UI#14806manu-gurudath wants to merge 55 commits into
manu-gurudath wants to merge 55 commits into
Conversation
manu-gurudath
marked this pull request as draft
August 31, 2026 02:05
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Can we add the name into the billing address/card details area? People ask us about that a lot. |
Restore the missing ERB tag in _grant_details, and make the controls grid's buttons consistent: every cell is now a .grant-control column whose button is bottom-pinned and full-width, matched as a descendant so button_to's display:contents form no longer breaks the selector. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The _section_heading partial required an "own" local with no default, but the pre-authorization page renders it without one, raising StrictLocalsError. Default own to true so the numbered steps still show. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6yqqwNR5bJJcy6Ej6kpqs
Keep main's separate converted/canceled branches for the grantee view and update the organizer show spec for the renamed section headings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VfcHsCGBdbSLfcH9BYtqpX
manu-gurudath
marked this pull request as ready for review
October 3, 2026 22:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@itmadden , can you please do a 2nd pass here? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






every day, there's a new confused user in #hcb asking a card-grant related question
here are the biggest changes this pr does:
preview
cc @anishanne