Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked draft: depends on #447, #448 and #449. Keep draft until the prerequisites land, then rebase to remove their commits from this diff. The benchmark implementation is isolated in commit 07207e9; later commits restrict workflow credentials and document a measured resource limit.
Add a standalone ESP-IDF 6.1 benchmark for S3/S31 with ESP and macOS peers. The ESP drives echo, asymmetric request/response, directional streams and duplex independently of its GAP role. A versioned frame parser handles split/coalesced SDUs; streaming uses validated receipts and a final completion fence rather than per-DATA application ACKs.
The serial runner retains complete per-frame evidence, requested versus accepted radio parameters, firmware/config hashes, warmups, reconnect heap samples and failed partial captures. Comparisons keep different link parameters/roles separate. A Foundation-only shared codec and macOS reflector are published separately at mickeyl/core-bluetooth-tool@6124827 . The iPhone peer is not included.
Validation:
No experimental HCI window, MPS alignment, native private-header diagnostics, private captures, generated full SDK configs or machine-specific paths are included. The existing GATT examples/workflows remain separate; new CI compiles the benchmark and checks its evidence codecs. The measured transfer times are host/application metrics, not physical RF throughput or synchronized one-way delays.
Final clean-image HIL audit: ten successful captures / 42 measured runs, 608 echo/request exchanges and 128 streaming DATA frames across 16 completed connections. The maximum-SDU failures are excluded from those totals.