Ensure episode_title is still populated for repacks#788
Open
noxxusnx wants to merge 1 commit intoguessit-io:developfrom
Open
Ensure episode_title is still populated for repacks#788noxxusnx wants to merge 1 commit intoguessit-io:developfrom
episode_title is still populated for repacks#788noxxusnx wants to merge 1 commit intoguessit-io:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #775
The issue was the
matches.previous(hole)would contain[<Proper:(19, 25)+name=other+tags=['streaming_service.prefix', 'streaming_service.suffix']>]which didn't match the previous names we were looking for.Adding
otherto the previous names broke other tests so I opted for adding arepacktag for this case since it felt more appropriate than usingstreaming_service.prefixorstreaming_service.suffixfor this condition.From there I just added another case to the lamda to also match it when the hole had the
repacktag which resolved my case and didn't break any other tests.