WIP S3 SDK upgrade#4719
Draft
andrew-nowak wants to merge 6 commits into
Draft
Conversation
andrew-nowak
commented
May 1, 2026
| lazy val client: S3Client = S3Ops.buildS3Client(config) | ||
| lazy val presigner = S3Presigner.create() | ||
|
|
||
| def signUrl(bucket: Bucket, url: URI, image: Image, expiration: DateTime = cachableExpiration(), imageType: ImageFileType = Source): String = { |
Member
Author
There was a problem hiding this comment.
turns out nothing's ever caching the presigned urls, so no need to round to make cacheable?
(if we do need this, it's annoying as v2 sdk only allows you to specify an expiry duration, not an expiry time, and expiry time is calculated internally against a call to Instant.now(), so impossible to guarantee urls match!)
andrew-nowak
force-pushed
the
an/s3-sdk-upgrade-complete
branch
from
4548d4e to
12724a0
Compare
andrew-nowak
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?