Skip to content

Gradle 9 with configuration cache issue #322 fix #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
souvikadh wants to merge 1 commit into from
Closed

Gradle 9 with configuration cache issue #322 fix #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions libs/gretty/src/main/groovy/org/akhikhl/gretty/GrettyPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,15 +225,19 @@ class GrettyPlugin implements Plugin<Project> {
group = 'gretty'
description = 'Copies webAppDir of this web-app and all overlays (if any) to ${buildDir}/inplaceWebapp'

def getInplaceMode = {
project.tasks.findByName('appRun').effectiveInplaceMode
// Capture inplaceMode at configuration time to avoid accessing project at execution time
def inplaceModeProvider = project.provider {
def appRunTask = project.tasks.findByName('appRun')
appRunTask?.effectiveInplaceMode ?: 'soft'
}

// We should track changes in inplaceMode value or plugin would show UP-TO-DATE for this task
// even if inplaceMode was changed
inputs.property('inplaceMode', getInplaceMode)
inputs.property('inplaceMode', inplaceModeProvider)

onlyIf { getInplaceMode() != 'hard' }
onlyIf {
inplaceModeProvider.get() != 'hard'
}

// Attention: call order is important here! Overlay files must be copied prior to this web-app files.

Expand All @@ -248,6 +252,7 @@ class GrettyPlugin implements Plugin<Project> {
duplicatesStrategy = DuplicatesStrategy.INCLUDE

def closure = project.gretty.webappCopy
closure.resolveStrategy = Closure.DELEGATE_FIRST
closure = closure.rehydrate(it, closure.owner, closure.thisObject)
closure()

Expand Down
Loading