Repository navigation
fix(scripts): find an openssl that can do Ed25519 - #8
Merged
Merged
Conversation
macOS ships LibreSSL as /usr/bin/openssl and it cannot generate Ed25519 keys. The script would have produced an empty key and set a useless secret on any machine where that one is first on PATH — it only worked here because Homebrew OpenSSL 3.6.4 shadows it. It now probes candidates for an actual Ed25519 keygen and says what to install if none can, instead of failing silently three commands later. Resolver tested: picks /opt/homebrew/bin/openssl, derives 64-char hex and 44-char base64. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V5hFP2B2vU4dUMYgM1NEVs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS ships LibreSSL as
/usr/bin/openssl, and it cannot generate Ed25519 keys.rotate-registry-key.shcalled bareopenssl, so on any machine where that one is first on PATH it would have produced an empty key and set a useless secret. It only worked here because Homebrew's OpenSSL 3.6.4 shadows it.The script now probes candidates for a working Ed25519 keygen — bare
openssl, then the two Homebrewopenssl@3paths — and tells you tobrew install openssl@3if none can, instead of failing three commands later.The existing length checks would have caught it, but only after the secret was already set.
Verified: the resolver picks
/opt/homebrew/bin/openssland derives 64-char hex / 44-char base64.bash -nclean.Credit where due — the old
LAUNCH-MCP-DIRECTORIES.mdrunbook in the gateway repo already warned about this. I rediscovered it the hard way.🤖 Generated with Claude Code
https://claude.ai/code/session_01V5hFP2B2vU4dUMYgM1NEVs