Add: agent-control-postgres and skiron-postgres - #97
Draft
pascalholthaus wants to merge 2 commits into
Draft
pascalholthaus wants to merge 2 commits into
pascalholthaus wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Image initialization, SBOM publication, and backward compatibility for service inputs need to be addressed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Agent Control and Skiron PostgreSQL services, including additional image publishing and service-specific image routing.
Changes:
- Publishes images to two registry repositories.
- Adds both services to scheduled upgrades.
- Routes service-specific image URLs through the upgrade matrix.
File summaries
| File | Description |
|---|---|
.github/workflows/push.yml |
Builds multiple images and routes services to their image repositories. |
.github/workflows/push-scheduled.yml |
Adds scheduled Agent Control and Skiron PostgreSQL upgrades. |
Review details
Suppressed comments (2)
.github/workflows/push-scheduled.yml:29
- These entries are only handed to
push.ymlthroughpush-compare, but that workflow decides whether to callpush.ymlsolely by comparingopensight-dev/opensight-postgres(seepush-compare.yml:28-42). If that image is already current when this change lands, the scheduled job skips the build, so the newopenvas-enterprise-container-dev/openvas-enterprise-container-postgresrepository is never populated and these services cannot pull the requested tag until a later PostgreSQL update. Please make the compare/initialization path check the new repository or explicitly trigger an initial build.
{"service":"openvas-agent-control-postgres","image-url":"openvas-enterprise-container-dev/openvas-enterprise-container-postgres"},
{"service":"openvas-skiron-postgres","image-url":"openvas-enterprise-container-dev/openvas-enterprise-container-postgres"}
.github/workflows/push.yml:58
- Adding this second repository here does not bootstrap it or detect drift: the scheduled path first runs
push-compare.yml, whose compare job only checksopensight-dev/opensight-postgres. If that existing tag is current whileopenvas-enterprise-container-dev/openvas-enterprise-container-postgresis absent or stale,push.ymlis skipped and these new service upgrades have no image to pull. Compare both targets or add an explicit first-publish path.
openvas-enterprise-container-dev/openvas-enterprise-container-postgres
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pascalholthaus
force-pushed
the
pascalholthaus-patch-6
branch
from
September 17, 2026 12:18
f2c8dfb to
e9b698e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add: agent-control-postgres and skiron-postgres
Why
CPB-848
References
CPB-848