Skip to content

Add: agent-control-postgres and skiron-postgres - #97

Draft
pascalholthaus wants to merge 2 commits into
mainfrom
pascalholthaus-patch-6
Draft

pascalholthaus wants to merge 2 commits into
mainfrom
pascalholthaus-patch-6

Conversation

@pascalholthaus

Copy link
Copy Markdown
Contributor

What

Add: agent-control-postgres and skiron-postgres

Why

CPB-848

References

CPB-848

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Image initialization, SBOM publication, and backward compatibility for service inputs need to be addressed.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds Agent Control and Skiron PostgreSQL services, including additional image publishing and service-specific image routing.

Changes:

  • Publishes images to two registry repositories.
  • Adds both services to scheduled upgrades.
  • Routes service-specific image URLs through the upgrade matrix.
File summaries
File Description
.github/workflows/push.yml Builds multiple images and routes services to their image repositories.
.github/workflows/push-scheduled.yml Adds scheduled Agent Control and Skiron PostgreSQL upgrades.
Review details

Suppressed comments (2)

.github/workflows/push-scheduled.yml:29

  • These entries are only handed to push.yml through push-compare, but that workflow decides whether to call push.yml solely by comparing opensight-dev/opensight-postgres (see push-compare.yml:28-42). If that image is already current when this change lands, the scheduled job skips the build, so the new openvas-enterprise-container-dev/openvas-enterprise-container-postgres repository is never populated and these services cannot pull the requested tag until a later PostgreSQL update. Please make the compare/initialization path check the new repository or explicitly trigger an initial build.
                {"service":"openvas-agent-control-postgres","image-url":"openvas-enterprise-container-dev/openvas-enterprise-container-postgres"},
                {"service":"openvas-skiron-postgres","image-url":"openvas-enterprise-container-dev/openvas-enterprise-container-postgres"}

.github/workflows/push.yml:58

  • Adding this second repository here does not bootstrap it or detect drift: the scheduled path first runs push-compare.yml, whose compare job only checks opensight-dev/opensight-postgres. If that existing tag is current while openvas-enterprise-container-dev/openvas-enterprise-container-postgres is absent or stale, push.yml is skipped and these new service upgrades have no image to pull. Compare both targets or add an explicit first-publish path.
            openvas-enterprise-container-dev/openvas-enterprise-container-postgres
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/push.yml Outdated
Comment thread .github/workflows/push.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants