Skip to content

fix: clarify retry exhaust notification wording - #261

Merged
mgoetzegb merged 2 commits into
mainfrom
ARTOSI-1163-clarify-retry-exhaust-notifications
Oct 20, 2026
Merged

mgoetzegb merged 2 commits into
mainfrom
ARTOSI-1163-clarify-retry-exhaust-notifications

Conversation

@mgoetzegb

Copy link
Copy Markdown
Member

What

fix: clarify retry exhaust notification wording

Why

Clarify that only the specific notification is no longer retried, not the whole channel in general.

References

ARTOSI-1163

@mgoetzegb
mgoetzegb requested review from a team as code owners September 30, 2026 10:29
@github-actions

Copy link
Copy Markdown

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.54%. Comparing base (1ae2dfe) to head (83b629b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files          66       66           
  Lines        2023     2023           
=======================================
  Hits         1063     1063           
  Misses        960      960           
Flag Coverage Δ
unit-tests 52.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/services/notificationservice/notificationService.go Outdated
jwulfheide-gb
jwulfheide-gb previously approved these changes Oct 20, 2026
Clarify that only the specific notification is no longer retried, not the whole channel in general.
@mgoetzegb
mgoetzegb force-pushed the ARTOSI-1163-clarify-retry-exhaust-notifications branch from 96532c4 to 83b629b Compare October 20, 2026 10:58
@mgoetzegb
mgoetzegb enabled auto-merge (squash) October 20, 2026 10:58
@mgoetzegb
mgoetzegb merged commit 28009b8 into main Oct 20, 2026
15 checks passed
@mgoetzegb
mgoetzegb deleted the ARTOSI-1163-clarify-retry-exhaust-notifications branch October 20, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants