Conversation
Only validate the scanner port when it is provided. This allows sensor scanners to be created without requiring a port value.
greenbonebot
enabled auto-merge (rebase)
September 24, 2026 06:51
mattmundell
reviewed
Sep 24, 2026
| "<ca_pub>%s</ca_pub>" | ||
| "<credential id=\"%s\"/>" | ||
| "</create_scanner>", | ||
| name, comment, host, port, type, ca_pub, |
Contributor
There was a problem hiding this comment.
If port can be NULL then I think these two gmpfs should have NULL checks on port
Member
Author
There was a problem hiding this comment.
you're right that I will handle this on GSA side and closing this PR
auto-merge was automatically disabled
September 24, 2026 08:39
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the scanner port optional in GSAD.
Only validate the port when a value is provided.
Why
Sensor scanners do not require users to provide a port, so GSAD should allow the port field to be omitted.
References
GEA-2095