Skip to content

Added missing code to save several values from the agent task dialog. - #448

Merged
bjoernricks merged 14 commits into
mainfrom
GEA-2022_Min_QoD_not_configurable_for_Agent_tasks
Sep 22, 2026
Merged

bjoernricks merged 14 commits into
mainfrom
GEA-2022_Min_QoD_not_configurable_for_Agent_tasks

Conversation

@jhelmold

@jhelmold jhelmold commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

What

Added missing code to save the values "in assets", "apply overrides" and "min qod" from the agent task dialog in gvmd.

Why

This was a bug.

References

GEA-2022

Checklist

Tested manually on my local development system.

@jhelmold
jhelmold marked this pull request as ready for review August 28, 2026 11:36
@jhelmold
jhelmold requested review from a team as code owners August 28, 2026 11:36
@greenbonebot
greenbonebot enabled auto-merge (rebase) August 28, 2026 11:36
Comment thread src/gsad_gmp.c Outdated
Comment thread src/gsad_gmp.c Outdated
Comment thread src/gsad_gmp.c Outdated
Comment thread src/gsad_gmp.c Outdated
…ithub.com:greenbone/gsad into GEA-2022_Min_QoD_not_configurable_for_Agent_tasks
@codecov

codecov Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (aa4ea13) to head (d69d837).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          32       32           
  Lines        5093     5093           
  Branches      144      144           
=======================================
  Hits         4844     4844           
  Misses        180      180           
  Partials       69       69           
Flag Coverage Δ
unittests 95.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhelmold
jhelmold requested a review from bjoernricks September 7, 2026 11:58
Comment thread src/gsad_gmp.c Outdated
Comment thread src/gsad_gmp.c Outdated
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 22, 2026 08:20
…ithub.com:greenbone/gsad into GEA-2022_Min_QoD_not_configurable_for_Agent_tasks
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 22, 2026 08:22
@bjoernricks
bjoernricks enabled auto-merge (squash) September 22, 2026 08:26
@bjoernricks
bjoernricks merged commit 62295ef into main Sep 22, 2026
19 checks passed
@bjoernricks
bjoernricks deleted the GEA-2022_Min_QoD_not_configurable_for_Agent_tasks branch September 22, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants