Repository navigation
Query Hooks Improvements - #5681
Draft
bjoernricks wants to merge 23 commits into
Draft
bjoernricks wants to merge 23 commits into
bjoernricks wants to merge 23 commits into
Conversation
Use dedicated modules for single and multiple entity query hooks.
Use dedicated modules for single and multiple entity query hooks.
Ensure when cloning and deleting tickets via their query hooks a notification message is displayed.
Use dedicated describe blocks for each hook and use real model instances in the tests.
Ensure when cloning and deleting users via their query hooks a notification message is displayed.
Allow to query Target data via use query hooks.
As query hooks might not return a response object and instead the data directly the goToDetails function needs to support this use case.
Refactor TargetComponent to use the new query hooks for target.
Before the changed port list was re-loaded after a port range was deleted. This is completely unnecessary and also created several additional requests when a user deleted several port ranges in the dialog.
Allow to query and mutate port lists via query hooks.
Use the new port list query hooks within the PortListComponent.
Implement the basic set of query hooks for credentials.
Update TargetComponent and TargetDialog to use the new port list and credential query hooks internally instead of directly querying the gmp API.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Entity and entities queries are separated everywhere else already.
For deleting a user an additional input argument is required.
It's not required for GMP.
…ssage Ensure that the name argument is passed by default and the type checker complains about it. This ensure the success message is displayed correctly.
Use useDeleteMutation and adapt arguments to recent changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Query Hooks Improvements
Extend and improve the query hooks to make them consistent.
Why
We should have one dedicated API for querying data. This means we should get rid of
Checklist