Repository navigation
Query Roles and Groups - #5680
Merged
Merged
Conversation
Add react hooks for querying the groups and roles.
… and groups Replace using the gmp layer directly by using the new query hooks inside the user dialog to load the available groups and roles.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
greenbonebot
enabled auto-merge (rebase)
October 2, 2026 11:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
==========================================
+ Coverage 87.51% 87.60% +0.09%
==========================================
Files 1304 1306 +2
Lines 34294 34302 +8
Branches 10291 10295 +4
==========================================
+ Hits 30011 30051 +40
+ Misses 3873 3844 -29
+ Partials 410 407 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Query Hooks for Roles and Groups and use them for the UserDialog
Why
Better abstraction and single point for the data loading. At the end the UI should use query hooks (at least mostly) and no redux anymore.
References
Checklist