Repository navigation
Improve Usablility for changing User Access Hosts - #5676
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
greenbonebot
enabled auto-merge (rebase)
October 1, 2026 08:26
bjoernricks
force-pushed
the
user-access-hosts
branch
from
October 1, 2026 08:33
99f5dba to
28d3513
Compare
bjoernricks
marked this pull request as draft
October 1, 2026 09:08
auto-merge was automatically disabled
October 1, 2026 09:08
Pull request was converted to draft
bjoernricks
marked this pull request as ready for review
October 1, 2026 09:12
greenbonebot
enabled auto-merge (rebase)
October 1, 2026 09:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5676 +/- ##
==========================================
+ Coverage 87.36% 87.43% +0.06%
==========================================
Files 1304 1304
Lines 34292 34289 -3
Branches 10287 10284 -3
==========================================
+ Hits 29959 29979 +20
+ Misses 3919 3897 -22
+ Partials 414 413 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow for better representation of CSV values in the UI. This improves the usability of the UserDialog component. Actually the access hosts are a list of string values. With this change everywhere in GSA the access hosts are represented as an array and are only converted to CSV when using the backend API.
Ensure saving and creating users via the User Dialog works as expected.
bjoernricks
force-pushed
the
user-access-hosts
branch
from
October 1, 2026 10:14
0dc3da2 to
677db13
Compare
daniele-mng
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve Usablility for changing User Access Hosts by using a tagging like text input field.
Also update all user create and save variables to camelCase.
Why
The access hosts contain a CSV value which is actually a list of values. Therefore represent the values as an array of strings.
References
https://jira.greenbone.net/browse/GEA-1973
Checklist