Repository navigation
Remove dataTransform from DataDisplay - #5662
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
==========================================
+ Coverage 87.06% 87.36% +0.30%
==========================================
Files 1304 1304
Lines 34137 34292 +155
Branches 10325 10287 -38
==========================================
+ Hits 29721 29959 +238
+ Misses 3977 3919 -58
+ Partials 439 414 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bjoernricks
force-pushed
the
data-display-types
branch
2 times, most recently
from
September 30, 2026 08:08
5952029 to
ab9a232
Compare
bjoernricks
marked this pull request as ready for review
September 30, 2026 08:08
greenbonebot
enabled auto-merge (rebase)
September 30, 2026 08:08
daniele-mng
reviewed
Oct 1, 2026
This change will make all DataDisplay much easier to understand. They just render some specific kind of data. No transformed data no transformed props.
Remove transforming of the input data and expect the transformed data directly.
dataTransform prop got removed and the re-usable chart displays expect the already transformed data now.
Update the loader to use the same meaning for isLoading as tenstack query. isLoading is only true if there isn't any data yet. This allows to remove this extra logic from DataDisplay that did exactly this and changed the isLoading meaning for its children.
Create all chart displays in the same manner by using the createDisplay function. This avoids duplicate code and will be easier for future refactoring.
Ensure the click handlers on the chart displays work as expected and legends are not toggleable were disabled.
The return data is now an array with a total property.
bjoernricks
force-pushed
the
data-display-types
branch
from
October 1, 2026 08:21
bb94782 to
8cfddfb
Compare
daniele-mng
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove dataTransform from DataDisplay
isLoadingmeaning already into the loader and change it to reflect tanstack query's behaviorcreateDisplayto generate all chart displaysWhy
Make the DataDisplay easier to understand and allow to replace Loaders with something else in future easily. This reduced the complexity of the display types a lot. This PR is allows for easier refactoring of the charts in future.
References
https://jira.greenbone.net/browse/GEA-2019
Checklist