Skip to content

Refactor DataDisplay to a function component - #5658

Merged
greenbonebot merged 1 commit into
mainfrom
data-display-as-function-component
Sep 24, 2026
Merged

greenbonebot merged 1 commit into
mainfrom
data-display-as-function-component

Conversation

@bjoernricks

Copy link
Copy Markdown
Contributor

What

Refactor DataDisplay to a function component

Convert the DataDisplay class component to a function component and keep its current behavior.

Why

Function components are easier to understand and to maintain.

References

https://jira.greenbone.net/browse/GEA-2019

Checklist

  • I have added tests for the changes
  • I have used the following LLMs/AI tools in this pull request:

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 55d62b3.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.05%. Comparing base (34c1581) to head (55d62b3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/web/components/dashboard/display/DataDisplay.tsx 96.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5658   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files        1304     1304           
  Lines       34103    34093   -10     
  Branches    10235    10196   -39     
=======================================
- Hits        29688    29681    -7     
+ Misses       3978     3975    -3     
  Partials      437      437           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjoernricks
bjoernricks force-pushed the data-display-as-function-component branch from 21b45e2 to aa04bea Compare September 24, 2026 10:48
@bjoernricks
bjoernricks marked this pull request as ready for review September 24, 2026 10:48
@bjoernricks
bjoernricks requested a review from a team as a code owner September 24, 2026 10:48
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 24, 2026 10:48
Convert the DataDisplay class component to a function component and keep
its current behavior.
@bjoernricks
bjoernricks force-pushed the data-display-as-function-component branch from aa04bea to 55d62b3 Compare September 24, 2026 11:52
@greenbonebot
greenbonebot merged commit f38fd56 into main Sep 24, 2026
25 checks passed
@greenbonebot
greenbonebot deleted the data-display-as-function-component branch September 24, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants