Skip to content

fix: hide port field for sensor scanners - #5656

Merged
greenbonebot merged 2 commits into
mainfrom
fix/hide-sensor-scanner-port
Sep 24, 2026
Merged

greenbonebot merged 2 commits into
mainfrom
fix/hide-sensor-scanner-port

Conversation

@ozgen

@ozgen ozgen commented Sep 24, 2026

Copy link
Copy Markdown
Member

What

Hide the port field for sensor scanners in the scanner dialog.

Sensor scanners continue to use port 0 internally.

Why

Users do not need to configure a port for sensor scanners, so the port field should not be shown in the UI.

References

GEA-2095

Checklist

  • I have added tests for the changes

@ozgen
ozgen requested a review from a team as a code owner September 24, 2026 08:15
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 24, 2026 08:15
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA ae40a39.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@ozgen
ozgen force-pushed the fix/hide-sensor-scanner-port branch from 334e4b0 to e07a1db Compare September 24, 2026 08:38
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.05%. Comparing base (a92f799) to head (ae40a39).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5656   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files        1304     1304           
  Lines       34097    34103    +6     
  Branches    10190    10195    +5     
=======================================
+ Hits        29682    29688    +6     
  Misses       3978     3978           
  Partials      437      437           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hide the port field for Greenbone Sensor, Agent Sensor, and OpenVASD Sensor
scanner types.

Sensor scanners use port 0 internally and do not require users to provide
a port.
@bjoernricks
bjoernricks force-pushed the fix/hide-sensor-scanner-port branch from 2c3afb4 to ae40a39 Compare September 24, 2026 10:01
@greenbonebot
greenbonebot merged commit 34c1581 into main Sep 24, 2026
23 checks passed
@greenbonebot
greenbonebot deleted the fix/hide-sensor-scanner-port branch September 24, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants