Skip to content

fix: disable cloning for Agent Controller and Sensor scanners - #5605

Merged
greenbonebot merged 1 commit into
mainfrom
fix/disable-agent-controller-cloning
Sep 11, 2026
Merged

fix: disable cloning for Agent Controller and Sensor scanners#5605
greenbonebot merged 1 commit into
mainfrom
fix/disable-agent-controller-cloning

Conversation

@ozgen

@ozgen ozgen commented Sep 11, 2026

Copy link
Copy Markdown
Member

What

  • Disable cloning for Agent Controller and Agent Controller Sensor scanners.
  • Disable the clone action for these scanner types.

Why

Agent Controller scanners must use a unique host and port.

Cloning these scanners can create another scanner pointing to the same Agent Controller endpoint, which can lead to duplicate agent synchronization and inconsistent scanner-agent associations.

References

GEA-2011

Checklist

  • I have added tests for the changes

@ozgen
ozgen requested a review from a team as a code owner September 11, 2026 09:15
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 11, 2026 09:15
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f38b7fb.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (4300dfe) to head (f38b7fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5605   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files        1293     1293           
  Lines       33774    33776    +2     
  Branches    10122    10124    +2     
=======================================
+ Hits        28778    28780    +2     
  Misses       4494     4494           
  Partials      502      502           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjoernricks
bjoernricks force-pushed the fix/disable-agent-controller-cloning branch from 1641595 to f38b7fb Compare September 11, 2026 11:37
@greenbonebot
greenbonebot merged commit 615d0e4 into main Sep 11, 2026
23 checks passed
@greenbonebot
greenbonebot deleted the fix/disable-agent-controller-cloning branch September 11, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants