Skip to content

95 provide a first page template#120

Merged
AMorgaut merged 4 commits into
mainfrom
95-provide-a-first-page-template
Sep 10, 2025
Merged

95 provide a first page template#120
AMorgaut merged 4 commits into
mainfrom
95-provide-a-first-page-template

Conversation

@jasdubourg

Copy link
Copy Markdown
Contributor

No description provided.

@jasdubourg jasdubourg linked an issue Aug 14, 2025 that may be closed by this pull request
@AMorgaut
AMorgaut force-pushed the 95-provide-a-first-page-template branch from 952f62b to e26d6b9 Compare August 15, 2025 13:05
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread apps/vue-app/src/components/pages/DashboardPage.vue Outdated
Comment thread shared/vue-ui/src/index.js Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.stories.js Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated
Comment thread shared/vue-ui/src/pages/ScorePage.vue Outdated

@AMorgaut AMorgaut left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: almost done! Thank you

See bellow Few proposals to make it even better

Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.stories.js
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.vue Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.vue Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.vue Outdated
Comment thread shared/vue-ui/src/page-templates/DashboardPageTemplate.vue Outdated
@AMorgaut
AMorgaut force-pushed the 95-provide-a-first-page-template branch from e516c79 to e5a05f7 Compare September 9, 2025 09:14
@AMorgaut
AMorgaut force-pushed the 95-provide-a-first-page-template branch from e5a05f7 to 5367cc7 Compare September 10, 2025 07:35
@sonarqubecloud

Copy link
Copy Markdown

@AMorgaut
AMorgaut merged commit 6f8db69 into main Sep 10, 2025
3 of 4 checks passed
@AMorgaut
AMorgaut deleted the 95-provide-a-first-page-template branch September 10, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a first Page template

2 participants