Open
Conversation
Member
If we decide that this is too aggressive to do by default, then my opinion would be that the normalization is so simple that there is not much value in having it in the plugin behind an opt-in flag. In that case, I would just recommend that we document it in the plugin README or similar. |
gabrielfeo
reviewed
Sep 18, 2025
Co-authored-by: Gabriel Féo <gfeo@gradle.com>
Co-authored-by: Gabriel Féo <gfeo@gradle.com>
Co-authored-by: Gabriel Féo <gfeo@gradle.com>
gabrielfeo
reviewed
Sep 19, 2025
Co-authored-by: Gabriel Féo <gfeo@gradle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add runtime classpath normalization for
java/lang/invoke/**inJdkImageWorkaround.We’ve observed persistent differences on JavaCompile inputs in Android projects even after applying the Android Cache Fix Plugin. These differences stem from JDK image layout/path variations that surface under java/lang/invoke. See the prior discussion in issue #341 for background and examples.
My impression is that this approach might be a bit aggressive. Should we instead do the inverse, where the default behavior is to not apply the normalization?