feat(tutorial): refine editor-leave confirmation and course success modal navigation

[Ethanlita]

Summary

Introduce an editor-owned extension point for the "leave editor" confirmation and use it to refine the tutorial experience, so tutorial features can adjust the editor's leave behavior .

User-facing changes

• Tutorial-aware leave confirmation. While a tutorial course is active, the "Leave editor" confirmation explains that tutorial edits will not be saved; outside tutorials it keeps the existing behavior.
• No redundant confirmation for expected course navigation. Explicit, expected navigations away from the editor via the course success modal no longer pop the leave confirmation:
  • continuing to the next course, and
  • returning to the course series from the success modal.
• Course success modal links back to the series. The success modal's secondary action is "Back to series courses", which opens the current course's series page (/course-series/:id). ("Learn next course" is unchanged.)

Implementation & design

• New editor-owned controller components/editor/leave-confirm.ts (editorLeaveConfirm) — a generic extension point for the editor's leave confirmation:
  • messageOverride — replace the confirmation copy.
  • requestSkipOnce / consumeSkipOnce — skip the confirmation for a single, expected navigation. The skip is time-bound, so a request that is never consumed (e.g. an editor → editor route update, or starting a course from a non-editor page, neither of which reaches onBeforeRouteLeave) cannot get stuck and silently suppress a later, genuine leave.
• The editor stays unaware of tutorials. The editor page's onBeforeRouteLeave guard only reads editorLeaveConfirm. The tutorial layer drives it, the same way it drives copilot: TutorialRoot sets the tutorial copy while a course is active (and clears it on cleanup), and startCourse / the success modal request the skip. There is no components/editor → components/tutorials dependency, and pages/editor no longer imports useTutorial.

Validation

• npm run type-check, npm run lint, and editing.test.ts (22 tests) pass.

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to skip the editor's leave confirmation dialog during explicit, expected navigation actions (such as starting a new course or returning to the course series page) and updates the confirmation message to be tutorial-specific when in a tutorial. Feedback was provided regarding a potential bug where the skip-confirmation flag could get "stuck" as true if navigating between editor routes (which triggers onBeforeRouteUpdate instead of onBeforeRouteLeave). A time-bound expiration mechanism was suggested to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[fennoai]

Summary

The time-bounded skip-flag design is solid — the comments clearly explain both what the mechanism does and why expiry is necessary. The correctness tradeoff (a skip request that is never consumed can suppress a genuine leave within its 1 s window) is explicitly acknowledged in the PR commit messages, which is good. A few issues worth addressing before merge:

Ordering risk in handleBackToCourseSeries — requestSkipLeaveConfirm() is called after emit('cancelled'). If the parent's cancelled handler takes any time, the 1 s window starts later than necessary. Moving requestSkipLeaveConfirm() to be the first call in the function minimises the gap and removes dependence on the parent handler's cost:

function handleBackToCourseSeries() {
  props.tutorial.requestSkipLeaveConfirm() // first
  emit('cancelled')
  router.push(`/course-series/${props.series.id}`)
}

Unhandled router.push rejection — router.push(...) returns a promise that can reject (navigation guard cancellation, NavigationDuplicated, etc.). handleStartNextCourse is already wrapped in useMessageHandle; it's worth adding a .catch or similar error handling to handleBackToCourseSeries as well, consistent with the surrounding code.

Button label capitalisation — 'Back to Series Courses' uses Title Case, while every other button in this file and neighbouring pages uses sentence case ('Learn next course', 'Back to apps', 'Back to users'). Should be 'Back to series courses'.

Comment/label mismatch — tutorial.ts line ~73 quotes the button as "back to course series", but the actual label is "Back to Series Courses" (word order differs too). Should match the rendered string.

zh copy inconsistency — The tutorial and project leave-confirm messages use different confirmation verbs: 确认要离开吗 vs 确定要离开吗. Aligning them avoids a subtle inconsistency in the UX.

[nighca]

跳过 confirm 的逻辑放到 TutorialCourseSuccessModal.vue 中调用 startCourse 的地方做可能更合适？按我们讨论的结论，不是所有的 startCourse 都应该跳过 confirm 的，只是 TutorialCourseSuccessModal 中那个 startCourse 行为才应该跳过

[nighca]

通过单独的机制来避免跟 editor 跟 tutorial 逻辑的耦合，这个思路我觉得没问题。不过现在这个 editor-leave-confirm 稍微有点重，我在想能不能借用已有的 editing-dirty 来达到这次的目的；比如 class Editing 增加个方法来重置 dirty 状态，现在 requestSkipOnce 的地方通过重置 dirty 状态来跳过检查？

[nighca]

这个文案跟默认文案表达的信息差别并不大，有没有可能优化默认文案来让它在不同场景下都比较合适，而不是针对 tutorial 使用不一样的文案？