Env by app

[nighca]

No description provided.

[gemini-code-assist]

Code Review

This pull request refactors the application configuration by removing the global environment file and introducing explicit configuration functions and environment objects for the 'account' and 'xbuilder' apps. This prevents modules from directly importing global environment variables. The review feedback highlights a bug in the parseSampleRate helper where a valid sample rate of 0 incorrectly triggers the fallback value, an out-of-order variable declaration within imports in EditorNavbar.vue, and a potential memory leak/redundant setup issue in initUserState if called multiple times.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The parseSampleRate function uses parseFloat(value) || fallback. If the sample rate is explicitly configured as 0 (which is a valid setting to disable tracing/sampling), parseFloat(value) evaluates to 0, causing the function to incorrectly fall back to the default value (0.1).

Use isNaN to check if the parsed value is valid instead.

Suggested change

	function parseSampleRate(value: string, fallback: number) {
	return parseFloat(value) || fallback
	}
	function parseSampleRate(value: string, fallback: number) {
	const parsed = parseFloat(value)
	return isNaN(parsed) ? fallback : parsed
	}

[gemini-code-assist]

The parseSampleRate function uses parseFloat(value) || fallback. If the sample rate is explicitly configured as 0 (which is a valid setting to disable tracing/sampling), parseFloat(value) evaluates to 0, causing the function to incorrectly fall back to the default value (0.1).

Use isNaN to check if the parsed value is valid instead.

Suggested change

	function parseSampleRate(value: string, fallback: number) {
	return parseFloat(value) || fallback
	}
	function parseSampleRate(value: string, fallback: number) {
	const parsed = parseFloat(value)
	return isNaN(parsed) ? fallback : parsed
	}

[gemini-code-assist]

The variable declaration const { showTutorialsEntry } = getXBuilderConfig() is placed in the middle of the import statements block. All import statements must precede any other code execution or variable declarations at the module level to adhere to standard style guidelines (such as ESLint's import/first rule) and prevent potential hoisting or initialization issues.

Please move this statement below all the import statements (e.g., right before const props = defineProps(...)).

[gemini-code-assist]

If multiple widgets or apps are loaded on the same page, initUserState may be called multiple times. This will register multiple redundant watchEffect listeners on the global userState reactive object, leading to duplicate writes to localStorage and potential memory leaks.

Add an early return if userStateConfig is already initialized to prevent redundant setup.

Suggested change

	export function initUserState(config: UserStateConfig) {
	userStateConfig = config
	oauthFlow = new OAuthFlow<{ returnTo: string }>(oauthApis, {
	clientId: config.accountOAuthClientId,
	redirectUri: `${window.location.origin}/sign-in/callback`
	})
	export function initUserState(config: UserStateConfig) {
	if (userStateConfig != null) return
	userStateConfig = config
	oauthFlow = new OAuthFlow<{ returnTo: string }>(oauthApis, {
	clientId: config.accountOAuthClientId,
	redirectUri: `${window.location.origin}/sign-in/callback`
	})