Skip to content

fix(helpers): respect --format flag in sheets +append, +read, and docs +write #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuthalapativarun wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(helpers): respect --format flag in sheets +append, +read, and docs +write #703

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b73417
fix(helpers): respect --format flag in sheets +append, +read, and doc…
nuthalapativarun Apr 6, 2026
6dbe0ba
fixup: read --format from parent ArgMatches; avoid variable shadowing
nuthalapativarun Apr 6, 2026
563087c
fixup: revert sub_matches rename; read format and dry-run from subcom…
nuthalapativarun Apr 6, 2026
8334dbf
fixup: use sub_matches for subcommand args; read global flags from pa…
nuthalapativarun Apr 6, 2026
6adaf33
fix(helpers): use sub_matches to read --format in +write, +append, +read
nuthalapativarun Apr 12, 2026
231fb77
fix(helpers): read --format from top-level matches, not sub_matches
nuthalapativarun Apr 12, 2026
1e10e10
fix(helpers): use sub_matches for --format flag
nuthalapativarun Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/helpers-respect-format-flag.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@googleworkspace/cli": patch
---

Fix `--format` flag being silently ignored in sheets and docs helpers

`sheets +append`, `sheets +read`, and `docs +write` all hard-coded
`OutputFormat::default()` (JSON) when calling `executor::execute_method`,
meaning `--format table`, `--format yaml`, and `--format csv` had no effect.
The handlers now read the global `--format` flag from `ArgMatches` and pass
it through to the executor, consistent with how `calendar +agenda` and
`gmail +triage` already behave.
10 changes: 7 additions & 3 deletions crates/google-workspace-cli/src/helpers/docs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,12 @@ TIPS:
_sanitize_config: &'a crate::helpers::modelarmor::SanitizeConfig,
) -> Pin<Box<dyn Future<Output = Result<bool, GwsError>> + Send + 'a>> {
Box::pin(async move {
if let Some(matches) = matches.subcommand_matches("+write") {
let (params_str, body_str, scopes) = build_write_request(matches, doc)?;
if let Some(sub_matches) = matches.subcommand_matches("+write") {
let (params_str, body_str, scopes) = build_write_request(sub_matches, doc)?;
let output_format = matches
.get_one::<String>("format")
.map(|s| crate::formatter::OutputFormat::from_str(s))
.unwrap_or_default();
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.

let scope_strs: Vec<&str> = scopes.iter().map(|s| s.as_str()).collect();
let (token, auth_method) = match auth::get_token(&scope_strs).await {
Expand Down Expand Up @@ -104,7 +108,7 @@ TIPS:
&pagination,
None,
&crate::helpers::modelarmor::SanitizeMode::Warn,
&crate::formatter::OutputFormat::default(),
&output_format,
false,
)
.await?;
Expand Down
20 changes: 14 additions & 6 deletions crates/google-workspace-cli/src/helpers/sheets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,13 @@ TIPS:
_sanitize_config: &'a crate::helpers::modelarmor::SanitizeConfig,
) -> Pin<Box<dyn Future<Output = Result<bool, GwsError>> + Send + 'a>> {
Box::pin(async move {
if let Some(matches) = matches.subcommand_matches("+append") {
let config = parse_append_args(matches);
if let Some(sub_matches) = matches.subcommand_matches("+append") {
let config = parse_append_args(sub_matches);
let (params_str, body_str, scopes) = build_append_request(&config, doc)?;
let output_format = matches
.get_one::<String>("format")
.map(|s| crate::formatter::OutputFormat::from_str(s))
.unwrap_or_default();
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.

let scope_strs: Vec<&str> = scopes.iter().map(|s| s.as_str()).collect();
let (token, auth_method) = match auth::get_token(&scope_strs).await {
Expand Down Expand Up @@ -149,17 +153,21 @@ TIPS:
&pagination,
None,
&crate::helpers::modelarmor::SanitizeMode::Warn,
&crate::formatter::OutputFormat::default(),
&output_format,
false,
)
.await?;

return Ok(true);
}

if let Some(matches) = matches.subcommand_matches("+read") {
let config = parse_read_args(matches);
if let Some(sub_matches) = matches.subcommand_matches("+read") {
let config = parse_read_args(sub_matches);
let (params_str, scopes) = build_read_request(&config, doc)?;
let output_format = matches
.get_one::<String>("format")
.map(|s| crate::formatter::OutputFormat::from_str(s))
.unwrap_or_default();
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.
Comment thread
nuthalapativarun marked this conversation as resolved.
Outdated
Comment thread
nuthalapativarun marked this conversation as resolved.

// Re-find method
let spreadsheets_res = doc.resources.get("spreadsheets").ok_or_else(|| {
Expand Down Expand Up @@ -192,7 +200,7 @@ TIPS:
&executor::PaginationConfig::default(),
None,
&crate::helpers::modelarmor::SanitizeMode::Warn,
&crate::formatter::OutputFormat::default(),
&output_format,
false,
)
.await?;
Expand Down
Loading