Repository navigation
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Author
|
/gcbrun |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
tests: runlabel is added to a fork PR (including Renovate PRs fromrenovate-bot),conformance.ymltriggers onpull_request_target: types: [labeled]to remove the one-shottests: runlabel, and previously attempted to check out the fork PR's SHA and build/run./toolboxin that samepull_request_targetjob.Starting in
actions/checkout@v7.0.0,actions/checkoutblocks checking out fork PR code inside apull_request_targetworkflow (Error: Refusing to check out fork pull request code from a 'pull_request_target' workflow), causing thepull_request_targetconformancerun to fail and overwrite the passingpull_requestconformancecheck.This PR aligns
conformance.ymlwith#2671by:- Isolating the
tests: runlabel cleanup into a dedicatedremove-labeljob (pull_request_target) that never checks out code.- Running the
conformancejob exclusively onpull_requestwithcontents: readpermissions.PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
review
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>