Repository navigation
fix(oracle): support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword, Passwordless Wallet/SEPS Support - #3485
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for passwordless Oracle Wallet authentication (SEPS/External Authentication) and telemetry tracking, alongside PL/SQL block execution support. Specifically, it makes database credentials conditional when using the OCI driver with a wallet, configures the godror driver using configDir instead of manipulating environment variables, and injects user-agent telemetry into connections. Additionally, it enables PL/SQL block execution (BEGIN/DECLARE) and updates documentation, prebuilt configurations, and unit tests accordingly. There are no review comments to address, and the changes look solid.
|
Can we separate the Open Telemetry support with the PL/SQL fix? The password auth fix is submitted in #3389 by a contributor so we'll move forward with that one, but feel free to leave comments on it. Thanks! |
c2422c9 to
b468dfc
Compare
|
/gcbrun |
Description
fix: #2044 add support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword.
fix: #3389 Update the mutating os.Setenv block and passed configDir directly to the godror driver connection string. This ensures thread safety and prevents lazy-connection-opening failures (ORA-12154).
Prebuilt list_tables Query: Replaced with NVL(:1, t.table_name) to bind the positional parameter exactly once, resolving parameter mismatches.
Documentation: Updated both source.md and prebuilt oracle.md to reflect the new configurations and added standard vs. wallet setup examples.
feat: add telemetry tracing and user-agent propagation to Oracle database connections
🛠️ Fixes #2044 #3389