Skip to content

fix(oracle): support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword, Passwordless Wallet/SEPS Support - #3485

Open
dumians wants to merge 2 commits into
googleapis:mainfrom
dumians:oracle-tools-skills
Open

dumians wants to merge 2 commits into
googleapis:mainfrom
dumians:oracle-tools-skills

Conversation

@dumians

@dumians dumians commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Description

fix: #2044 add support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword.

fix: #3389 Update the mutating os.Setenv block and passed configDir directly to the godror driver connection string. This ensures thread safety and prevents lazy-connection-opening failures (ORA-12154).
Prebuilt list_tables Query: Replaced with NVL(:1, t.table_name) to bind the positional parameter exactly once, resolving parameter mismatches.
Documentation: Updated both source.md and prebuilt oracle.md to reflect the new configurations and added standard vs. wallet setup examples.

feat: add telemetry tracing and user-agent propagation to Oracle database connections

🛠️ Fixes #2044 #3389

@dumians
dumians requested a review from a team as a code owner June 21, 2026 09:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for passwordless Oracle Wallet authentication (SEPS/External Authentication) and telemetry tracking, alongside PL/SQL block execution support. Specifically, it makes database credentials conditional when using the OCI driver with a wallet, configures the godror driver using configDir instead of manipulating environment variables, and injects user-agent telemetry into connections. Additionally, it enables PL/SQL block execution (BEGIN/DECLARE) and updates documentation, prebuilt configurations, and unit tests accordingly. There are no review comments to address, and the changes look solid.

@duwenxin99 duwenxin99 changed the title fix: support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword, Passwordless Wallet/SEPS Support fix(oracle): support for executing Oracle PL/SQL blocks via RunSQL - Oracle raises error when the query uses "RETURN" keyword, Passwordless Wallet/SEPS Support Jun 22, 2026
Comment thread docs/en/integrations/oracle/source.md Resolved
Comment thread docs/en/integrations/oracle/source.md Resolved
Comment thread internal/sources/oracle/oracle.go Resolved
@duwenxin99

Copy link
Copy Markdown
Contributor

Can we separate the Open Telemetry support with the PL/SQL fix? The password auth fix is submitted in #3389 by a contributor so we'll move forward with that one, but feel free to leave comments on it. Thanks!

@duwenxin99 duwenxin99 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 26, 2026
@duwenxin99 duwenxin99 added the status: waiting for response Status: reviewer is awaiting feedback or responses from the author before proceeding. label Aug 3, 2026
@dumians
dumians force-pushed the oracle-tools-skills branch from c2422c9 to b468dfc Compare November 6, 2026 11:58
@dumians

dumians commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

/gcbrun

@dumians
dumians requested a review from duwenxin99 November 8, 2026 05:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p2 Moderately-important priority. Fix may not be included in next release. status: waiting for response Status: reviewer is awaiting feedback or responses from the author before proceeding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oracle DB: issues with passwordless authentication + Oracle wallet Oracle raises error when the query uses "RETURN" keyword

2 participants