Skip to content

Fix email error copy#12420

Open
benbowler wants to merge 3 commits intodevelopfrom
enhancement/12157-fix-email-error-copy
Open

Fix email error copy#12420
benbowler wants to merge 3 commits intodevelopfrom
enhancement/12157-fix-email-error-copy

Conversation

@benbowler
Copy link
Copy Markdown
Collaborator

@benbowler benbowler commented Apr 1, 2026

Summary

Addresses issue:

Relevant technical choices

There was some confusion on which email copy to use. This sheet should be used as the single source of truth. This PR fixes the copy.

While I was here I removed a few error keys that were removed through discusson on the error sheet and are no longer used.

I also moved get_body_args to the Content_Map as part of parallel work to decouple the tester plugin so that it doesn't duplicate copy.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler changed the title Enhancement/12157 fix email error copy Fx email error copy Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

🎭 Playwright reports for 423974c:

📦 Build files for 423974c:

@benbowler benbowler changed the title Fx email error copy Fix email error copy Apr 1, 2026
@tofumatt tofumatt changed the base branch from develop to main April 1, 2026 21:25
@tofumatt tofumatt changed the base branch from main to develop April 1, 2026 21:25
Copy link
Copy Markdown
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are good, but because this is a release issue but the base branch is develop, I'll cherry-pick these commits into a branch based on main and merge that into main 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants