Open
Conversation
📚 Storybook for dfd4276: 📦 Build files for dfd4276:
🎭 Playwright reports for dfd4276: |
|
Size Change: 0 B Total Size: 2.31 MB ℹ️ View Unchanged
|
zutigrm
commented
Mar 31, 2026
assets/js/components/email-reporting/UserSettingsSelectionPanel/index.test.js
Show resolved
Hide resolved
aaemnnosttv
reviewed
Apr 1, 2026
Collaborator
aaemnnosttv
left a comment
aaemnnosttv
left a comment
There was a problem hiding this comment.
I see @tofumatt is reviewing as well, just adding a few thoughts.
Comment on lines
119
to
120
| Email_Reporting_Settings::FREQUENCY_WEEKLY => 7, | ||
| Email_Reporting_Settings::FREQUENCY_MONTHLY => 30, | ||
| Email_Reporting_Settings::FREQUENCY_QUARTERLY => 90, |
Collaborator
There was a problem hiding this comment.
We shouldn't use a fixed number of days here as the only period which has a fixed length is weekly.
Collaborator
There was a problem hiding this comment.
Indeed, as part of this issue (even though it's not mentioned in the ACs), we're best off using the number of days in the respective quarter, same as we do for each month.
Originally I thought that this constant is inaccurately-named, as the text is actually "last 90 days", but we should either label the intent is clearly to send an email every quarter:
Let's update this as part of this issue as well.
Collaborator
There was a problem hiding this comment.
We should have the endDate defined here to have an explicit date range. sendDate doesn't really matter so long as its after the end date as long as the date ranges to use are fixed.
Collaborator
Author
There was a problem hiding this comment.
Good point, I am not sure (can't recall the reason) why early on, we went with sendDate
tofumatt
requested changes
Apr 1, 2026
Collaborator
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
The change to monthly looks good, but as Evan mentioned: let's update the quarterly logic as well to fix the fixed-dates for both date ranges as part of this one issue 👍🏻
Comment on lines
119
to
120
| Email_Reporting_Settings::FREQUENCY_WEEKLY => 7, | ||
| Email_Reporting_Settings::FREQUENCY_MONTHLY => 30, | ||
| Email_Reporting_Settings::FREQUENCY_QUARTERLY => 90, |
Collaborator
There was a problem hiding this comment.
Indeed, as part of this issue (even though it's not mentioned in the ACs), we're best off using the number of days in the respective quarter, same as we do for each month.
Originally I thought that this constant is inaccurately-named, as the text is actually "last 90 days", but we should either label the intent is clearly to send an email every quarter:
Let's update this as part of this issue as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist