Remove Ads Conversion ID from Analytics and migrate setting.#12394
Merged
eugene-manuilov merged 9 commits intodevelopfrom Apr 16, 2026
Merged
Remove Ads Conversion ID from Analytics and migrate setting.#12394eugene-manuilov merged 9 commits intodevelopfrom
eugene-manuilov merged 9 commits intodevelopfrom
Conversation
📚 Storybook for 652f906:
📦 Build files for 652f906:
🎭 Playwright reports for 652f906: |
|
Size Change: 0 B Total Size: 2.27 MB ℹ️ View Unchanged
|
eugene-manuilov
requested changes
Apr 2, 2026
Collaborator
eugene-manuilov
left a comment
eugene-manuilov
left a comment
There was a problem hiding this comment.
Thanks, @tofumatt. There is some more work to do here.
Collaborator
There was a problem hiding this comment.
I know this has been added to IB, but we don't need this migration. There is nothing to migrate here. Let's remove this class.
Collaborator
Author
There was a problem hiding this comment.
We've previously removed unneeded/unused keys from settings with other migrations; wouldn't it make sense to remove it now that it's no longer in use? It's not strictly needed but seems like good housekeeping 🤔
Collaborator
There was a problem hiding this comment.
No, we don't need this migration. If we need to move something to another place or convert it to a different format, then we would need this migration class.
tofumatt
commented
Apr 7, 2026
Collaborator
Author
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
The ACs explicitly state the 'adsConversionID' key should stick around, so I didn't remove it to meet the ACs.
I can remove the new migration if desired but to remove the 'adsConversionID' key I'll need to modify the old migration as well—let me know if you'd like that, but in that case we need to adjust the ACs.
Collaborator
|
Ok, sounds good, @tofumatt. Let's keep that |
tofumatt
force-pushed
the
remove-ads-analytics-11303
branch
from
4913ff0 to
098b036
Compare
eugene-manuilov
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist