Remove Ads Conversion ID from Analytics and migrate setting.#12394
Open
Remove Ads Conversion ID from Analytics and migrate setting.#12394
Conversation
📚 Storybook for 098b036: 📦 Build files for 098b036:
🎭 Playwright reports for 098b036: |
|
Size Change: 0 B Total Size: 2.31 MB ℹ️ View Unchanged
|
eugene-manuilov
requested changes
Apr 2, 2026
Collaborator
eugene-manuilov
left a comment
eugene-manuilov
left a comment
There was a problem hiding this comment.
Thanks, @tofumatt. There is some more work to do here.
Collaborator
There was a problem hiding this comment.
I know this has been added to IB, but we don't need this migration. There is nothing to migrate here. Let's remove this class.
Collaborator
There was a problem hiding this comment.
Same here, not needed.
| return array( | ||
| 'ownerID' => 0, | ||
| 'accountID' => '', | ||
| 'adsConversionID' => '', |
Collaborator
There was a problem hiding this comment.
I believe we also need to delete this one, right?
| 'webDataStreamID' => '', | ||
| 'measurementID' => '', | ||
| 'ownerID' => 0, | ||
| 'adsConversionID' => '', |
Collaborator
There was a problem hiding this comment.
This should also be removed. There are more occurrences in this file.
| $this->assertEqualSetsWithIndex( | ||
| array( | ||
| 'accountID' => '', | ||
| 'adsConversionID' => '', |
Collaborator
There was a problem hiding this comment.
Should also be deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist