Skip to content

Refactor Analytics 4 Configuration and Status Management Datapoints.#12393

Merged
nfmohit merged 5 commits intodevelopfrom
enhancement/11093-refactor-configuration-datapoints
Apr 6, 2026
Merged

Refactor Analytics 4 Configuration and Status Management Datapoints.#12393
nfmohit merged 5 commits intodevelopfrom
enhancement/11093-refactor-configuration-datapoints

Conversation

@ankitrox
Copy link
Copy Markdown
Collaborator

@ankitrox ankitrox commented Mar 27, 2026 •
edited by nfmohit
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026 •
edited
Loading

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📦 Build files for dcab049:

  • Build files have been deleted.

🎭 Playwright reports for dcab049:

abdelmalekkkkk
abdelmalekkkkk requested changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ankitrox. I left a couple minor comments. Thanks!

tests/phpunit/integration/Modules/Analytics_4/Datapoints/Get_Google_Tag_SettingsTest.php Outdated
$request = $this->datapoint->create_request( $data_request );
$this->analytics->get_client()->execute( $request );

$this->assertStringContainsString(
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more helpful to assert the full request URL to make sure the datapoint is hitting the right GTM service endpoint. WDYT?

includes/Modules/Analytics_4.php Outdated
'POST:set-google-tag-id-mismatch' => new Set_Google_Tag_ID_Mismatch(
array(
'transients' => $this->transients,
'service' => '',
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting service to empty string seems redundant as it already default to an empty string in the Datapoint class. Can we remove it?

includes/Modules/Analytics_4.php Outdated
array(
'transients' => $this->transients,
'settings' => $this->get_settings(),
'service' => '',
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

includes/Modules/Analytics_4.php Outdated
'POST:save-resource-data-availability-date' => new Save_Resource_Data_Availability_Date(
array(
'resource_data_availability_date' => $this->resource_data_availability_date,
'service' => '',
Copy link
Copy Markdown
Collaborator

@abdelmalekkkkk abdelmalekkkkk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@ankitrox
Copy link
Copy Markdown
Collaborator Author

ankitrox commented Mar 31, 2026

@abdelmalekkkkk Thank you for reviewing the PR. I've addressed the suggestions and assigning this to you for another pass.

@abdelmalekkkkk
Copy link
Copy Markdown
Collaborator

abdelmalekkkkk commented Apr 1, 2026

Thanks @ankitrox! LGTM ✅

I confirmed the CI failures are unrelated.

@ankitrox
Copy link
Copy Markdown
Collaborator Author

ankitrox commented Apr 3, 2026

Thanks @abdelmalekkkkk , I have added the QAB and resolved the conflicts in the PR, so assigning you again to check everything, if all looks good.

nfmohit
nfmohit approved these changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Note: I've verified that the failing E2E test in CI is unrelated to the changes in this PR.

@nfmohit nfmohit merged commit 40d4f68 into develop Apr 6, 2026
28 of 30 checks passed
@nfmohit nfmohit deleted the enhancement/11093-refactor-configuration-datapoints branch April 6, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abdelmalekkkkk abdelmalekkkkk abdelmalekkkkk approved these changes

@nfmohit nfmohit nfmohit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ankitrox @abdelmalekkkkk @nfmohit