Remove `Authentication\Owner_ID` by ankitrox · Pull Request #12361 · google/site-kit-wp

ankitrox · 2026-03-24T11:21:19Z

Summary

Addresses issue:

Remove Authentication\Owner_ID #11727

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

github-actions · 2026-03-24T11:24:02Z

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for ec0cf0c:

Storybook has been deleted.

📦 Build files for ec0cf0c:

Build files have been deleted.

🎭 Playwright reports for ec0cf0c:

github-actions · 2026-03-24T11:26:35Z

Size Change: 0 B

Total Size: 2.31 MB

ℹ️ View Unchanged

Filename	Size	Change
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css`	124 B	0 B
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js`	42.7 kB	0 B
`dist/assets/blocks/reader-revenue-manager/common/editor-styles.css`	307 B	0 B
`dist/assets/blocks/reader-revenue-manager/common/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js`	5.88 kB	0 B
`dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js`	5.07 kB	0 B
`dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js`	5.88 kB	0 B
`dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js`	5.07 kB	0 B
`dist/assets/blocks/sign-in-with-google/editor-styles.css`	84 B	0 B
`dist/assets/blocks/sign-in-with-google/editor-styles.js`	0 B	0 B	🆕
`dist/assets/blocks/sign-in-with-google/index.js`	18.6 kB	0 B
`dist/assets/css/googlesitekit-admin-css-********************.min.css`	67.1 kB	0 B
`dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	12.3 kB	0 B
`dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	846 B	0 B
`dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	8.89 kB	0 B
`dist/assets/js/146-********************.js`	963 B	0 B
`dist/assets/js/201-********************.js`	2.85 kB	0 B
`dist/assets/js/314-********************.js`	100 kB	0 B
`dist/assets/js/315-********************.js`	3.08 kB	0 B
`dist/assets/js/379-********************.js`	3.7 kB	0 B
`dist/assets/js/590-********************.js`	1.89 kB	0 B
`dist/assets/js/640-********************.js`	2.36 kB	0 B
`dist/assets/js/909-********************.js`	1.01 kB	0 B
`dist/assets/js/analytics-advanced-tracking-********************.js`	475 B	0 B
`dist/assets/js/googlesitekit-activation-********************.js`	25.1 kB	0 B
`dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	59.6 kB	0 B
`dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js`	5.35 kB	0 B
`dist/assets/js/googlesitekit-adminbar-********************.js`	36.1 kB	0 B
`dist/assets/js/googlesitekit-api-********************.js`	7.99 kB	0 B
`dist/assets/js/googlesitekit-block-tracking-********************.js`	5.55 kB	0 B
`dist/assets/js/googlesitekit-components-********************.js`	5.82 kB	0 B
`dist/assets/js/googlesitekit-consent-mode-********************.js`	25.5 kB	0 B
`dist/assets/js/googlesitekit-data-********************.js`	1.73 kB	0 B
`dist/assets/js/googlesitekit-datastore-forms-********************.js`	7.01 kB	0 B
`dist/assets/js/googlesitekit-datastore-location-********************.js`	1.51 kB	0 B
`dist/assets/js/googlesitekit-datastore-site-********************.js`	18.5 kB	-20 B (-0.11%)
`dist/assets/js/googlesitekit-datastore-ui-********************.js`	7.16 kB	0 B
`dist/assets/js/googlesitekit-datastore-user-********************.js`	23 kB	0 B
`dist/assets/js/googlesitekit-entity-dashboard-********************.js`	72.8 kB	0 B
`dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	1.27 kB	0 B
`dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	655 B	0 B
`dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	1.27 kB	0 B
`dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	1.26 kB	0 B
`dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	1.29 kB	0 B
`dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	1.34 kB	0 B
`dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	990 B	0 B
`dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	1.29 kB	0 B
`dist/assets/js/googlesitekit-i18n-********************.js`	6.16 kB	0 B
`dist/assets/js/googlesitekit-key-metrics-setup-********************.js`	53.4 kB	0 B
`dist/assets/js/googlesitekit-main-dashboard-********************.js`	149 kB	0 B
`dist/assets/js/googlesitekit-metric-selection-********************.js`	57.9 kB	0 B
`dist/assets/js/googlesitekit-modules-********************.js`	26.3 kB	0 B
`dist/assets/js/googlesitekit-modules-ads-********************.js`	48.9 kB	0 B
`dist/assets/js/googlesitekit-modules-adsense-********************.js`	138 kB	0 B
`dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	191 kB	0 B
`dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	23.6 kB	0 B
`dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	52.7 kB	0 B
`dist/assets/js/googlesitekit-modules-search-console-********************.js`	67.2 kB	0 B
`dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	34.7 kB	0 B
`dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	30.4 kB	0 B
`dist/assets/js/googlesitekit-notifications-********************.js`	68.5 kB	0 B
`dist/assets/js/googlesitekit-polyfills-********************.js`	230 B	0 B
`dist/assets/js/googlesitekit-settings-********************.js`	135 kB	0 B
`dist/assets/js/googlesitekit-splash-********************.js`	78.5 kB	0 B
`dist/assets/js/googlesitekit-user-input-********************.js`	51.3 kB	0 B
`dist/assets/js/googlesitekit-vendor-********************.js`	328 kB	0 B
`dist/assets/js/googlesitekit-widgets-********************.js`	104 kB	0 B
`dist/assets/js/googlesitekit-wp-dashboard-********************.js`	62.1 kB	0 B
`dist/assets/js/runtime-********************.js`	1.92 kB	0 B

_{compressed-size-action}

nfmohit

Thank you for working on this, @ankitrox!

I've left some minor feedback. Additionally, could you kindly add a QAB?

Thanks!

includes/Core/Authentication/Authentication.php

…/site-kit-wp into enhancement/11727-remove-owner-id.

ankitrox · 2026-04-03T14:36:04Z

Thanks @nfmohit for reviewing the PR. I've updated it as per the suggestions.

nfmohit

Thank you for addressing my feedback, @ankitrox!

While reviewing the PR again, I searched for the removed isOwner property, and I found two references:

site-kit-wp/storybook/utils/resetGlobals.js

Line 41 in 6d06d13

isOwner: true,

site-kit-wp/docs/context/php/asset-management.md

Line 517 in 6d06d13

'isOwner' => current_user_can( Permissions::MANAGE_OPTIONS ),

Shouldn't we also remove these?

ankitrox · 2026-04-06T04:45:26Z

Thanks @nfmohit , removed those references as they no longer seem to be required anymore.

nfmohit

LGTM, thanks @ankitrox ✅

Note: I've verified that the failing test in CI is unrelated to the changes in this PR.

Remove from code.

dc52e90

ankitrox changed the title ~~Remove from code.~~ Remove Authentication\Owner_ID Mar 24, 2026

ankitrox and others added 2 commits March 24, 2026 20:28

Remove redundant assertion.

2276408

Merge branch 'develop' into enhancement/11727-remove-owner-id.

324bd9e

nfmohit requested changes Apr 2, 2026

View reviewed changes

includes/Core/Authentication/Authentication.php Outdated Show resolved Hide resolved

includes/Core/Authentication/Authentication.php Outdated Show resolved Hide resolved

ankitrox added 3 commits April 2, 2026 18:35

Merge branch 'develop' into enhancement/11727-remove-owner-id.

b3e3b80

Merge branch 'enhancement/11727-remove-owner-id' of github.com:google…

7ef095c

…/site-kit-wp into enhancement/11727-remove-owner-id.

Remove redundant code.

6d06d13

nfmohit requested changes Apr 4, 2026

View reviewed changes

ankitrox added 2 commits April 6, 2026 09:54

Merge branch 'develop' into enhancement/11727-remove-owner-id.

c3a75da

Remove isOwner reference.

ec0cf0c

nfmohit approved these changes Apr 6, 2026

View reviewed changes

nfmohit merged commit e55e510 into develop Apr 6, 2026
37 of 39 checks passed

nfmohit deleted the enhancement/11727-remove-owner-id branch April 6, 2026 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `Authentication\Owner_ID`#12361

Remove `Authentication\Owner_ID`#12361
nfmohit merged 8 commits intodevelopfrom
enhancement/11727-remove-owner-id

ankitrox commented Mar 24, 2026 •

edited by nfmohit

Loading

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 24, 2026 •

edited

Loading

Uh oh!

nfmohit left a comment

Uh oh!

Uh oh!

Uh oh!

ankitrox commented Apr 3, 2026

Uh oh!

nfmohit left a comment

Uh oh!

ankitrox commented Apr 6, 2026

Uh oh!

nfmohit left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ankitrox commented Mar 24, 2026 • edited by nfmohit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ankitrox commented Apr 3, 2026

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

ankitrox commented Apr 6, 2026

Uh oh!

nfmohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ankitrox commented Mar 24, 2026 •

edited by nfmohit

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading