Merged
Conversation
|
Size Change: +434 B (+0.02%) Total Size: 2.31 MB ℹ️ View Unchanged
|
Collaborator
Author
|
Stylelint is failing for unrelated reasons, which is fixed in this PR #12330 |
Collaborator
Author
|
VRT is failing for some unrelated flakiness etc |
tofumatt
requested changes
Mar 19, 2026
Collaborator
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
A few string changes are needed, and I have some questions around operator use and the intention of the function based on a variable name that wasn't clear to me.
Mostly minor stuff though; otherwise looks good 👍🏻
I fixed the SCSS error in this PR as well.
assets/js/components/email-reporting/notices/errors/CronSchedulerErrorNotice.js
Outdated
Show resolved
Hide resolved
assets/js/components/email-reporting/notices/errors/CronSchedulerErrorNotice.test.js
Outdated
Show resolved
Hide resolved
assets/js/components/email-reporting/notices/EmailReportingErrorNotices.test.js
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if ( Email_Log::STATUS_SENT === get_post_status( $post_id ) && Email_Log::STATUS_SENT !== $previous_status ) { | ||
| ++$emails_processed; |
Collaborator
There was a problem hiding this comment.
Similarly—why use this over
Suggested change
| ++$emails_processed; | |
| $emails_processed++; |
tests/phpunit/integration/Core/Email_Reporting/Cron_Health_CheckTest.php
Show resolved
Hide resolved
tofumatt
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist