Polish guest register state API - #42
Merged
zhangxp1998 merged 1 commit intoJul 3, 2026
Merged
Conversation
qwandor
self-requested a review
June 25, 2026 16:34
m4tx
self-requested a review
June 26, 2026 09:17
qwandor
reviewed
Jun 30, 2026
zhangxp1998
force-pushed
the
followup/pr41-register-state-api
branch
from
July 3, 2026 05:31
c13bfb6 to
d5d1106
Compare
zhangxp1998
force-pushed
the
followup/pr41-register-state-api
branch
from
July 3, 2026 05:39
d5d1106 to
a662f9e
Compare
qwandor
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GuestRegisterStateRef::write_gprunsafe and return aResultfor invalid register indexes.exception_return()helper with named return address/status accessors.&mut NonVolatileRegistersinstead of a raw pointer.LazyLock, useArrayVec::is_full(), expose the remaining crate-local helpers aspub, and make read-result extension aDecodedMemoryAccessmethod.Follow-up for review comments left on #41 after it was merged.
Tests
cargo fmt --all -- --checkgit diff --checkmake build PLATFORM=qemumake test PLATFORM=qemumake clippy PLATFORM=qemu